Rtcp enhancements #914
Merged
Rtcp enhancements #914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Each RR packet can hold up to 31 reports. Do serialize multiple packets if the number of reports exceed 31.
Each Sdes packet can hold up to 31 chunks. Do serialize multiple packets
if the number of reports exceed 31.
So a single serialized packet can be sent out instead of sending multiple smaller packets.
The method gathers all needed RTCP itself.
Make sure CompoundPacket is filled before sending it. * Reduces memory allocations for new CompoundPacket instances. * Reduces the CPU and network overhead compared to sending smaller packets.
Set the interval to 1 second with a variation of [1..1.5]. Previously the interval was smaller as the send bandwidth increased getting too small values for large meetings.
ibc
approved these changes
Oct 3, 2022
|
This was merged without changes in CHANGELOG :( |
|
Changelog updated in the next commit. |
ibc
reviewed
Oct 25, 2022
Comment on lines
+205
to
+207
| size_t size = (Packet::CommonHeaderSize + 4u /* this->ssrc */) * | ||
| ((this->GetCount() / MaxReportsPerPacket) + 1); | ||
| size += ReceiverReport::HeaderSize * this->GetCount(); |
There was a problem hiding this comment.
Can you explain in detail this math?
There was a problem hiding this comment.
A Receiver Report packet is composed by:
- RTCP common header (Packet::CommonHeaderSize).
- SSRC of the packet sender. (4 bytes)
- Up to 31 reports. (Each report size is ReceiverReport::HeaderSize )
This method returns the size needed to represent all it's content.
There was a problem hiding this comment.
Why is (commonHeader size + 4) being multiplied by ((number of reports divided by max reports per packet) + 1)?
There was a problem hiding this comment.
We are calculating there how many receiver report packets (Common header + SSRC) we need, considering our packet instance packet can hold more than 31 receiver reports and the the maximum reports a serialized receiver report packet can contain is 31 (limit given by the 'count' header field in the RTCP common header).
piranna
pushed a commit
to dyte-in/mediasoup
that referenced
this pull request
Feb 9, 2023
* RTCP: ReceiverReportPacket, fix serization when report number > 31
Each RR packet can hold up to 31 reports. Do serialize multiple packets
if the number of reports exceed 31.
* RTCP: SdesPacket, fix serization when chunk number > 31
Each Sdes packet can hold up to 31 chunks. Do serialize multiple packets
if the number of reports exceed 31.
* RTCP: SenderReportPacket, serialize multiple SR packets at once
So a single serialized packet can be sent out instead of sending multiple
smaller packets.
* Consumer: GetRtcp() do not indicate a specific RtpStream
The method gathers all needed RTCP itself.
* RTCP: CompoundPacket, fill it up to the MTU before sending
Make sure CompoundPacket is filled before sending it.
* Reduces memory allocations for new CompoundPacket instances.
* Reduces the CPU and network overhead compared to sending smaller
packets.
* RTCP: CompoundPacket, serialize it in the corresponding sending method
* Transport: enhance RTCP send interval
Set the interval to 1 second with a variation of [1..1.5].
Previously the interval was smaller as the send bandwidth increased
getting too small values for large meetings.
* RTCP: CompoundPacket, avoid creating unneeded std::vector instances
* RTCP: Sdes, fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #907
Enhances RTCP compound packet sending:
NOTE: Please read the changes commit by commit.