Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rtcp enhancements #914

Merged
merged 9 commits into from
Oct 4, 2022
Merged

Rtcp enhancements #914

merged 9 commits into from
Oct 4, 2022

Commits on Sep 26, 2022

  1. RTCP: ReceiverReportPacket, fix serization when report number > 31 

    Each RR packet can hold up to 31 reports. Do serialize multiple packets
if the number of reports exceed 31.
    @jmillan
    jmillan committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    9efaa77 View commit details
    Browse the repository at this point in the history

  2. RTCP: SdesPacket, fix serization when chunk number > 31 

    Each Sdes packet can hold up to 31 chunks. Do serialize multiple packets
    if the number of reports exceed 31.
    @jmillan
    jmillan committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    d5b9369 View commit details
    Browse the repository at this point in the history

  3. RTCP: SenderReportPacket, serialize multiple SR packets at once 

    So a single serialized packet can be sent out instead of sending multiple
smaller packets.
    @jmillan
    jmillan committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    aea9f6d View commit details
    Browse the repository at this point in the history

  4. Consumer: GetRtcp() do not indicate a specific RtpStream 

    The method gathers all needed RTCP itself.
    @jmillan
    jmillan committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    5cae973 View commit details
    Browse the repository at this point in the history

  5. RTCP: CompoundPacket, fill it up to the MTU before sending 

    Make sure CompoundPacket is filled before sending it.

* Reduces memory allocations for new CompoundPacket instances.
* Reduces the CPU and network overhead compared to sending smaller
  packets.
    @jmillan
    jmillan committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    2c1d64f View commit details
    Browse the repository at this point in the history

  6. RTCP: CompoundPacket, serialize it in the corresponding sending method

    @jmillan
    jmillan committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    9cfe02a View commit details
    Browse the repository at this point in the history

  7. Transport: enhance RTCP send interval 

    Set the interval to 1 second with a variation of [1..1.5].

Previously the interval was smaller as the send bandwidth increased
getting too small values for large meetings.
    @jmillan
    jmillan committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    1b4064c View commit details
    Browse the repository at this point in the history

Commits on Sep 28, 2022

  1. RTCP: CompoundPacket, avoid creating unneeded std::vector instances

    @jmillan
    jmillan committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    6bb7ba7 View commit details
    Browse the repository at this point in the history

  2. RTCP: Sdes, fix typo

    @jmillan
    jmillan committed Sep 28, 2022
    Configuration menu
    Copy the full SHA
    47ca01e View commit details
    Browse the repository at this point in the history