Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update dynamic custom config but observedGeneration is not update #353

Closed
veezhang opened this issue Oct 18, 2023 · 3 comments
Closed

update dynamic custom config but observedGeneration is not update #353

veezhang opened this issue Oct 18, 2023 · 3 comments
Labels
affects/none PR/issue: this bug affects none version. find-by-e2e Bugs that find by e2e. process/fixed Process of bug severity/none Severity of bug type/bug Type: something is unexpected

Comments

@veezhang
Copy link
Contributor

Please check the FAQ documentation before raising an issue

When updating dynamic custom config v=1, it is found through the flags api that it has been processed, but observedGeneration has not been updated.

The NebulaCluster yaml:

kind: NebulaCluster
metadata:
  annotations:
    meta.helm.sh/release-name: e2e-nc-4-e7e03c0367784faa97d0ed6
    meta.helm.sh/release-namespace: e2e-nc-4-3c0fda7a67dc9b681c51730
  creationTimestamp: "2023-10-18T07:39:13Z"
  generation: 2
  labels:
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/version: 1.6.3
    helm.sh/chart: nebula-cluster-1.6.3
  name: e2e-nc-4-e7e03c0367784faa97d0ed6
  namespace: e2e-nc-4-3c0fda7a67dc9b681c51730
  resourceVersion: "133442244"
  uid: 0cdd7ae1-f01c-4ceb-8b4f-ef56b9f048bd
spec:
  agent:
    image: vesoft/nebula-agent
    resources:
      limits:
        cpu: 200m
        memory: 256Mi
      requests:
        cpu: 100m
        memory: 128Mi
    version: latest
  enableBR: false
  enablePVReclaim: false
  exporter:
    annotations: {}
    env: []
    httpPort: 9100
    image: vesoft/nebula-stats-exporter
    labels: {}
    maxRequests: 20
    replicas: 1
    resources:
      limits:
        cpu: 200m
        memory: 256Mi
      requests:
        cpu: 100m
        memory: 128Mi
    version: v3.3.0
  graphd:
    annotations: {}
    config:
      v: "1"
    env: []
    httpPort: 19669
    image: reg.vesoft-inc.com/vesoft-ent/nebula-graphd-ent
    labels: {}
    logVolumeClaim:
      resources:
        requests:
          storage: 500Mi
    port: 9669
    replicas: 2
    resources:
      limits:
        cpu: "1"
        memory: 500Mi
      requests:
        cpu: 500m
        memory: 500Mi
    service:
      externalTrafficPolicy: Local
      type: NodePort
    version: v3.5.1
  imagePullPolicy: Always
  imagePullSecrets:
  - name: image-pull-secret.e2e
  metad:
    annotations: {}
    config:
      v: "2"
    dataVolumeClaim:
      resources:
        requests:
          storage: 2Gi
    env: []
    httpPort: 19559
    image: reg.vesoft-inc.com/vesoft-ent/nebula-metad-ent
    labels: {}
    licenseManagerURL: license.vesoft-inc.com:9119
    logVolumeClaim:
      resources:
        requests:
          storage: 500Mi
    port: 9559
    replicas: 3
    resources:
      limits:
        cpu: "1"
        memory: 1Gi
      requests:
        cpu: 500m
        memory: 500Mi
    version: v3.5.1
  reference:
    name: statefulsets.apps
    version: v1
  schedulerName: default-scheduler
  storaged:
    annotations: {}
    config:
      v: "3"
    dataVolumeClaims:
    - resources:
        requests:
          storage: 10Gi
    enableAutoBalance: false
    enableForceUpdate: false
    env: []
    httpPort: 19779
    image: reg.vesoft-inc.com/vesoft-ent/nebula-storaged-ent
    labels: {}
    logVolumeClaim:
      resources:
        requests:
          storage: 500Mi
    port: 9779
    replicas: 3
    resources:
      limits:
        cpu: "1"
        memory: 1Gi
      requests:
        cpu: 500m
        memory: 500Mi
    version: v3.5.1
  topologySpreadConstraints:
  - topologyKey: kubernetes.io/hostname
    whenUnsatisfiable: ScheduleAnyway
status:
  conditions:
  - lastTransitionTime: "2023-10-18T07:40:17Z"
    lastUpdateTime: "2023-10-18T07:40:17Z"
    message: Nebula cluster is running
    reason: Ready
    status: "True"
    type: Ready
  graphd:
    phase: Running
    version: v3.5.1
    workload:
      availableReplicas: 2
      collisionCount: 0
      currentReplicas: 2
      currentRevision: e2e-nc-4-e7e03c0367784faa97d0ed6-graphd-59866c6464
      observedGeneration: 1
      readyReplicas: 2
      replicas: 2
      updateRevision: e2e-nc-4-e7e03c0367784faa97d0ed6-graphd-59866c6464
      updatedReplicas: 2
  metad:
    phase: Running
    version: v3.5.1
    workload:
      availableReplicas: 3
      collisionCount: 0
      currentReplicas: 3
      currentRevision: e2e-nc-4-e7e03c0367784faa97d0ed6-metad-dfd776967
      observedGeneration: 1
      readyReplicas: 3
      replicas: 3
      updateRevision: e2e-nc-4-e7e03c0367784faa97d0ed6-metad-dfd776967
      updatedReplicas: 3
  observedGeneration: 1
  storaged:
    hostsAdded: true
    phase: Running
    version: v3.5.1
    workload:
      availableReplicas: 3
      collisionCount: 0
      currentReplicas: 3
      currentRevision: e2e-nc-4-e7e03c0367784faa97d0ed6-storaged-6c55964488
      observedGeneration: 1
      readyReplicas: 3
      replicas: 3
      updateRevision: e2e-nc-4-e7e03c0367784faa97d0ed6-storaged-6c55964488
      updatedReplicas: 3
  version: 3.5.1-ent

check in flags api:

curl -s 10.233.92.171:19669/flags | grep  ^v=
v=1

Describe the bug (required)

Your Environments (required)

  • OS: uname -a
  • Commit id (e.g. a3ffc7d8)

How To Reproduce(required)

Steps to reproduce the behavior:

  1. Step 1
  2. Step 2
  3. Step 3

Expected behavior

Additional context
@veezhang veezhang added type/bug Type: something is unexpected find-by-e2e Bugs that find by e2e. labels Oct 18, 2023
@github-actions github-actions bot added affects/none PR/issue: this bug affects none version. severity/none Severity of bug labels Oct 18, 2023
@veezhang veezhang mentioned this issue Oct 19, 2023
Merged
3 tasks
@veezhang
Copy link
Contributor Author

Update Exporter version, alse do not update observedGeneration.

kind: NebulaCluster
metadata:
  annotations:
    meta.helm.sh/release-name: e2e-nc-6-aacf9c1f5e4c1f374f9830c
    meta.helm.sh/release-namespace: e2e-nc-6-71787c79ccbf4a192b897b4
  creationTimestamp: "2023-10-20T09:15:32Z"
  generation: 2
  labels:
    app.kubernetes.io/managed-by: Helm
    app.kubernetes.io/version: 1.7.0
    helm.sh/chart: nebula-cluster-1.7.0
  name: e2e-nc-6-aacf9c1f5e4c1f374f9830c
  namespace: e2e-nc-6-71787c79ccbf4a192b897b4
  resourceVersion: "134196512"
  uid: 4b519c36-60eb-436b-ae78-d327b4fa5a7f
spec:
  agent:
    image: vesoft/nebula-agent
    resources:
      limits:
        cpu: 200m
        memory: 256Mi
      requests:
        cpu: 100m
        memory: 128Mi
    version: latest
  enableBR: false
  enablePVReclaim: false
  exporter:
    annotations: {}
    env: []
    httpPort: 9100
    image: vesoft/nebula-stats-exporter
    labels: {}
    maxRequests: 20
    replicas: 1
    resources:
      limits:
        cpu: 200m
        memory: 256Mi
      requests:
        cpu: 100m
        memory: 128Mi
    version: latest
  graphd:
    annotations: {}
    config: {}
    env: []
    image: reg.vesoft-inc.com/vesoft-ent/nebula-graphd-ent
    labels: {}
    logVolumeClaim:
      resources:
        requests:
          storage: 500Mi
    replicas: 2
    resources:
      limits:
        cpu: "1"
        memory: 500Mi
      requests:
        cpu: 500m
        memory: 500Mi
    service:
      externalTrafficPolicy: Local
      type: NodePort
    version: v3.5.1
  imagePullPolicy: Always
  imagePullSecrets:
  - name: image-pull-secret.e2e
  metad:
    annotations: {}
    config: {}
    dataVolumeClaim:
      resources:
        requests:
          storage: 2Gi
    env: []
    image: reg.vesoft-inc.com/vesoft-ent/nebula-metad-ent
    labels: {}
    licenseManagerURL: license.vesoft-inc.com:9119
    logVolumeClaim:
      resources:
        requests:
          storage: 500Mi
    replicas: 3
    resources:
      limits:
        cpu: "1"
        memory: 1Gi
      requests:
        cpu: 500m
        memory: 500Mi
    version: v3.5.1
  reference:
    name: statefulsets.apps
    version: v1
  schedulerName: default-scheduler
  storaged:
    annotations: {}
    config: {}
    dataVolumeClaims:
    - resources:
        requests:
          storage: 10Gi
    enableAutoBalance: false
    enableForceUpdate: false
    env: []
    image: reg.vesoft-inc.com/vesoft-ent/nebula-storaged-ent
    labels: {}
    logVolumeClaim:
      resources:
        requests:
          storage: 500Mi
    replicas: 3
    resources:
      limits:
        cpu: "1"
        memory: 1Gi
      requests:
        cpu: 500m
        memory: 500Mi
    version: v3.5.1
  topologySpreadConstraints:
  - topologyKey: kubernetes.io/hostname
    whenUnsatisfiable: ScheduleAnyway
status:
  conditions:
  - lastTransitionTime: "2023-10-20T09:16:45Z"
    lastUpdateTime: "2023-10-20T09:16:45Z"
    message: Nebula cluster is running
    reason: Ready
    status: "True"
    type: Ready
  graphd:
    phase: Running
    version: v3.5.1
    workload:
      availableReplicas: 2
      collisionCount: 0
      currentReplicas: 2
      currentRevision: e2e-nc-6-aacf9c1f5e4c1f374f9830c-graphd-855698458
      observedGeneration: 1
      readyReplicas: 2
      replicas: 2
      updateRevision: e2e-nc-6-aacf9c1f5e4c1f374f9830c-graphd-855698458
      updatedReplicas: 2
  metad:
    phase: Running
    version: v3.5.1
    workload:
      availableReplicas: 3
      collisionCount: 0
      currentReplicas: 3
      currentRevision: e2e-nc-6-aacf9c1f5e4c1f374f9830c-metad-bdf5d8d66
      observedGeneration: 1
      readyReplicas: 3
      replicas: 3
      updateRevision: e2e-nc-6-aacf9c1f5e4c1f374f9830c-metad-bdf5d8d66
      updatedReplicas: 3
  observedGeneration: 1
  storaged:
    hostsAdded: true
    phase: Running
    version: v3.5.1
    workload:
      availableReplicas: 3
      collisionCount: 0
      currentReplicas: 3
      currentRevision: e2e-nc-6-aacf9c1f5e4c1f374f9830c-storaged-8497dbf569
      observedGeneration: 1
      readyReplicas: 3
      replicas: 3
      updateRevision: e2e-nc-6-aacf9c1f5e4c1f374f9830c-storaged-8497dbf569
      updatedReplicas: 3
  version: 3.5.1-ent

@veezhang veezhang mentioned this issue Oct 20, 2023
Merged
3 tasks
@veezhang
Copy link
Contributor Author

pvc expansion is also not update observedGeneration.

@veezhang veezhang mentioned this issue Oct 27, 2023
Merged
3 tasks
@MegaByte875
Copy link
Contributor

#399

@github-actions github-actions bot added the process/fixed Process of bug label Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects/none PR/issue: this bug affects none version. find-by-e2e Bugs that find by e2e. process/fixed Process of bug severity/none Severity of bug type/bug Type: something is unexpected
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MegaByte875 @veezhang