Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: e2e add dynamic custom config #361

Merged
merged 1 commit into from
Oct 20, 2023
Merged

Conversation

veezhang
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@veezhang veezhang requested review from MegaByte875 and kqzh October 19, 2023 09:27
@veezhang
Copy link
Contributor Author

There are still two issues(#353 #354) that need to be dealt with, and the dynamic custom config have not been passed yet.
The static custom config have been passed.

--- PASS: TestNebulaCluster (281.51s)
    --- SKIP: TestNebulaCluster/scale_with_default_values (0.00s)
    --- SKIP: TestNebulaCluster/update_version (0.00s)
    --- SKIP: TestNebulaCluster/update_resources (0.00s)
    --- PASS: TestNebulaCluster/custom_config_for_static (281.51s)
        --- PASS: TestNebulaCluster/custom_config_for_static/Install_NebulaCluster (1.03s)
        --- PASS: TestNebulaCluster/custom_config_for_static/Wait_NebulaCluster_to_be_ready (70.10s)
        --- PASS: TestNebulaCluster/custom_config_for_static/Upgrade_NebulaCluster_update_configs (1.12s)
        --- PASS: TestNebulaCluster/custom_config_for_static/Wait_NebulaCluster_to_be_ready_after_upgrade_update_configs (156.39s)
        --- PASS: TestNebulaCluster/custom_config_for_static/Upgrade_NebulaCluster_restart_pods (0.22s)
        --- PASS: TestNebulaCluster/custom_config_for_static/Wait_NebulaCluster_to_be_ready_after_upgrade_restart_pods (51.39s)
        --- PASS: TestNebulaCluster/custom_config_for_static/Uninstall_NebulaCluster (1.13s)
    --- SKIP: TestNebulaCluster/custom_config_for_dynamic (0.00s)
PASS

Copy link
Contributor

@MegaByte875 MegaByte875 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MegaByte875 MegaByte875 merged commit 1f9bc09 into vesoft-inc:master Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants