Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: e2e add pv expansion #380

Merged
merged 1 commit into from
Oct 27, 2023
Merged

feat: e2e add pv expansion #380

merged 1 commit into from
Oct 27, 2023

Conversation

veezhang
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@veezhang veezhang requested review from MegaByte875 and kqzh October 27, 2023 09:40
@veezhang
Copy link
Contributor Author

There are also the following things that need to be dealt with:

  1. need to update observedGeneration.
    update dynamic custom config but observedGeneration is not update #353 (comment)
  2. need to add check whether pvc is deleted or not.
    Internal optimization #337 (comment)

@veezhang
Copy link
Contributor Author

By manually updating observedGeneration, the test results are as follows:

--- PASS: TestNebulaCluster (574.22s)
    --- SKIP: TestNebulaCluster/scale_with_default_values (0.00s)
    --- SKIP: TestNebulaCluster/update_version (0.00s)
    --- SKIP: TestNebulaCluster/update_resources (0.00s)
    --- SKIP: TestNebulaCluster/custom_config_for_static (0.00s)
    --- SKIP: TestNebulaCluster/custom_config_for_dynamic (0.00s)
    --- SKIP: TestNebulaCluster/custom_config_thrift_port_and_http_port (0.00s)
    --- SKIP: TestNebulaCluster/tools_for_exporter (0.00s)
    --- SKIP: TestNebulaCluster/scale_with_zone (0.00s)
    --- SKIP: TestNebulaCluster/update_version_with_zone (0.00s)
    --- PASS: TestNebulaCluster/pv_expansion (224.11s)
        --- PASS: TestNebulaCluster/pv_expansion/Install_NebulaCluster (10.62s)
        --- PASS: TestNebulaCluster/pv_expansion/Wait_NebulaCluster_to_be_ready (57.27s)
        --- PASS: TestNebulaCluster/pv_expansion/Load_LDBC-SNB_dataset (111.62s)
        --- PASS: TestNebulaCluster/pv_expansion/Upgrade_NebulaCluster_update_storage_size (9.63s)
        --- PASS: TestNebulaCluster/pv_expansion/Wait_NebulaCluster_to_be_ready_after_upgrade_update_storage_size (22.42s)
        --- PASS: TestNebulaCluster/pv_expansion/Uninstall_NebulaCluster (8.81s)
    --- PASS: TestNebulaCluster/pv_expansion_with_EnablePVReclaim (350.11s)
        --- PASS: TestNebulaCluster/pv_expansion_with_EnablePVReclaim/Install_NebulaCluster (13.38s)
        --- PASS: TestNebulaCluster/pv_expansion_with_EnablePVReclaim/Wait_NebulaCluster_to_be_ready (61.91s)
        --- PASS: TestNebulaCluster/pv_expansion_with_EnablePVReclaim/Load_LDBC-SNB_dataset (116.10s)
        --- PASS: TestNebulaCluster/pv_expansion_with_EnablePVReclaim/Upgrade_NebulaCluster_update_storage_size (21.61s)
        --- PASS: TestNebulaCluster/pv_expansion_with_EnablePVReclaim/Wait_NebulaCluster_to_be_ready_after_upgrade_update_storage_size (128.11s)
        --- PASS: TestNebulaCluster/pv_expansion_with_EnablePVReclaim/Uninstall_NebulaCluster (7.77s)
PASS

Copy link
Contributor

@MegaByte875 MegaByte875 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MegaByte875 MegaByte875 merged commit b6d4799 into vesoft-inc:master Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants