Skip to content
This repository has been archived by the owner on Dec 1, 2022. It is now read-only.

use local id in the space range for tag edge index #501

Closed
wants to merge 1 commit into from
Closed

use local id in the space range for tag edge index #501

wants to merge 1 commit into from

Conversation

panda-sheep
Copy link
Contributor

@panda-sheep panda-sheep commented Jun 22, 2021 •
edited
Loading

As title

  1. Tag, edge, tag index and edge index use space range id.
  2. Compatible with the existing old schema creating previously.

@panda-sheep panda-sheep added the ready-for-testing PR: ready for the CI test label Jun 22, 2021
@panda-sheep panda-sheep force-pushed the use_local_id branch 2 times, most recently from 6c5c8c9 to 56c68c3 Compare June 24, 2021 10:59
@bright-starry-sky
Copy link
Contributor

I can't find where autoIncrementIdInSpace is used for create tag | edge .

@bright-starry-sky
Copy link
Contributor

I can't find where autoIncrementIdInSpace is used for create tag | edge .

This PR only deals with indexes, right?

@panda-sheep
Copy link
Contributor Author

I can't find where autoIncrementIdInSpace is used for create tag | edge .

This PR only deals with indexes, right?

tag, edge, tag index. edge index are all processed
I will immediately add another test with an existing schema

@bright-starry-sky
Copy link
Contributor

I can't find where autoIncrementIdInSpace is used for create tag | edge .

This PR only deals with indexes, right?

tag, edge, tag index. edge index are all processed
I will immediately add another test with an existing schema

yes, I saw what processed. good job.

@panda-sheep panda-sheep force-pushed the use_local_id branch 3 times, most recently from 8b3b18a to 89d07d7 Compare June 25, 2021 12:34
@panda-sheep
Copy link
Contributor Author

Ready, please continue.

bright-starry-sky
bright-starry-sky previously approved these changes Jun 26, 2021
View reviewed changes
Copy link
Contributor

@bright-starry-sky bright-starry-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@critical27
Copy link
Contributor

LGTM, wait the version has been released.

@panda-sheep panda-sheep mentioned this pull request Aug 23, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@critical27 critical27 critical27 left review comments

@bright-starry-sky bright-starry-sky bright-starry-sky left review comments

@darionyaphet darionyaphet Awaiting requested review from darionyaphet

@monadbobo monadbobo Awaiting requested review from monadbobo

@liuyu85cn liuyu85cn Awaiting requested review from liuyu85cn

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@panda-sheep @bright-starry-sky @critical27