Dss part1: use local id in the space range for tag edge index #2550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panda-sheep
force-pushed
the
use_local_id
branch
from
98ebdc1 to
a058610
Compare
panda-sheep
requested review from
bright-starry-sky,
cangfengzhs,
critical27,
darionyaphet and
liuyu85cn
|
Why need this? |
Data synchronization between clusters |
critical27
approved these changes
Aug 24, 2021
bright-starry-sky
approved these changes
Aug 24, 2021
|
|
Shylock-Hg
added
the
incompatible
panda-sheep
removed
the
incompatible
|
Please see the second, compatible with old data |
Shylock-Hg
reviewed
Aug 24, 2021
liuyu85cn
approved these changes
Aug 24, 2021
|
So now there are independent incremental id in separate spaces, the schema id will be same for different spaces, and this behavior different from before. For more compatible I think you could reuse the Global ID and just store them in the local id key to distinguish the owned space, and in this case the schema id in different space won't be same (they are still generated by global id) |
yixinglu
approved these changes
Aug 24, 2021
panda-sheep
changed the title
11 tasks
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Sep 14, 2023
Fix tagnum is not passed into GITHUB_OUTPUT Co-authored-by: George <58841610+Shinji-IkariG@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title
1） Tag, edge, tag index and edge index use space range id.
2） Compatible with the existing old schema creating previously.
Synchronize nebula-storage repo pr vesoft-inc/nebula-storage#501