Enhance the AppendVertices operator to avoid unnecessary rpc overhead (…

…#5018) * enhance/appendVerticeExecutor fix small delete small fix * small fix
vesoft-inc · Dec 8, 2022 · 42f5de3 · 42f5de3
1 parent 3762db7
commit 42f5de3
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 1 deletion.
diff --git a/src/graph/executor/query/AppendVerticesExecutor.cpp b/src/graph/executor/query/AppendVerticesExecutor.cpp
@@ -27,7 +27,7 @@ StatusOr<DataSet> AppendVerticesExecutor::buildRequestDataSet(const AppendVertic
 folly::Future<Status> AppendVerticesExecutor::appendVertices() {
   SCOPED_TIMER(&execTime_);
   auto *av = asNode<AppendVertices>(node());
-  if (FLAGS_optimize_appendvertices && av != nullptr && av->props() == nullptr) {
+  if (FLAGS_optimize_appendvertices && av != nullptr && av->noNeedFetchProp()) {
     return handleNullProp(av);
   }
 

diff --git a/src/graph/planner/plan/Query.h b/src/graph/planner/plan/Query.h
@@ -346,6 +346,28 @@ class GetVertices : public Explore {
     return props_.get();
   }
 
+  bool noNeedFetchProp() const {
+    if (props_.get() == nullptr) {
+      return true;
+    }
+    auto& vprops = *props_;
+    for (const auto& vprop : vprops) {
+      auto& props = vprop.get_props();
+      if (props.size() > 1) {
+        return false;
+      }
+      if (props.empty()) {
+        continue;
+      }
+      DCHECK_EQ(props.size(), 1);
+      auto& prop = props.front();
+      if (prop.compare("_tag")) {
+        return false;
+      }
+    }
+    return true;
+  }
+
   const std::vector<Expr>* exprs() const {
     return exprs_.get();
   }