Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the AppendVertices operator to avoid unnecessary rpc overhead #5018

Merged
merged 2 commits into from
Dec 8, 2022

Conversation

czpmango
Copy link
Contributor

@czpmango czpmango commented Dec 7, 2022

Do not make an rpc request if no need to fetch properties.

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@czpmango czpmango added ready-for-testing PR: ready for the CI test ready for review labels Dec 7, 2022
yixinglu
yixinglu previously approved these changes Dec 7, 2022
@yixinglu yixinglu requested review from jievince and Aiee December 7, 2022 13:05
@czpmango czpmango changed the title enhance/appendVerticeExecutor Enhance the AppendVertices operator to avoid unnecessary rpc overhead Dec 8, 2022
fix

small delete

small fix
@yixinglu yixinglu requested a review from jievince December 8, 2022 03:34
@yixinglu yixinglu merged commit 42f5de3 into vesoft-inc:master Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants