Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance the AppendVertices operator to avoid unnecessary rpc overhead #5018

Merged
merged 2 commits into from
Dec 8, 2022
Merged

Enhance the AppendVertices operator to avoid unnecessary rpc overhead #5018

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4655639
enhance/appendVerticeExecutor
czpmango Dec 7, 2022
fefc026
small fix
czpmango Dec 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/graph/executor/query/AppendVerticesExecutor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ StatusOr<DataSet> AppendVerticesExecutor::buildRequestDataSet(const AppendVertic
folly::Future<Status> AppendVerticesExecutor::appendVertices() {
SCOPED_TIMER(&execTime_);
auto *av = asNode<AppendVertices>(node());
if (FLAGS_optimize_appendvertices && av != nullptr && av->props() == nullptr) {
if (FLAGS_optimize_appendvertices && av != nullptr && av->noNeedFetchProp()) {
return handleNullProp(av);
}

Expand Down
22 changes: 22 additions & 0 deletions src/graph/planner/plan/Query.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,28 @@ class GetVertices : public Explore {
return props_.get();
}

bool noNeedFetchProp() const {
if (props_.get() == nullptr) {
return true;
}
auto& vprops = *props_;
for (const auto& vprop : vprops) {
auto& props = vprop.get_props();
if (props.size() > 1) {
yixinglu marked this conversation as resolved.
Show resolved Hide resolved
return false;
}
if (props.empty()) {
continue;
}
DCHECK_EQ(props.size(), 1);
auto& prop = props.front();
if (prop.compare("_tag")) {
return false;
}
}
return true;
}

const std::vector<Expr>* exprs() const {
return exprs_.get();
}
Expand Down