Update config about KV separation threshold (#3879)

* update config * lint
vesoft-inc · Feb 16, 2022 · 6975efd · 6975efd
1 parent 17c5755
commit 6975efd
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/conf/nebula-storaged.conf.default b/conf/nebula-storaged.conf.default
@@ -98,8 +98,8 @@
 ############## Key-Value separation ##############
 # Whether or not to enable BlobDB (RocksDB key-value separation support)
 --rocksdb_enable_kv_separation=false
-# RocksDB key value separation threshold. Values at or above this threshold will be written to blob files during flush or compaction.
---rocksdb_kv_separation_threshold=0
+# RocksDB key value separation threshold in bytes. Values at or above this threshold will be written to blob files during flush or compaction.
+--rocksdb_kv_separation_threshold=100
 # Compression algorithm for blobs, options: no,snappy,lz4,lz4hc,zlib,bzip2,zstd
 --rocksdb_blob_compression=lz4
 # Whether to garbage collect blobs during compaction

diff --git a/conf/nebula-storaged.conf.production b/conf/nebula-storaged.conf.production
@@ -104,8 +104,8 @@
 ############## Key-Value separation ##############
 # Whether or not to enable BlobDB (RocksDB key-value separation support)
 --rocksdb_enable_kv_separation=false
-# RocksDB key value separation threshold. Values at or above this threshold will be written to blob files during flush or compaction.
---rocksdb_kv_separation_threshold=0
+# RocksDB key value separation threshold in bytes. Values at or above this threshold will be written to blob files during flush or compaction.
+--rocksdb_kv_separation_threshold=100
 # Compression algorithm for blobs, options: no,snappy,lz4,lz4hc,zlib,bzip2,zstd
 --rocksdb_blob_compression=lz4
 # Whether to garbage collect blobs during compaction

diff --git a/src/kvstore/RocksEngineConfig.cpp b/src/kvstore/RocksEngineConfig.cpp
@@ -123,9 +123,9 @@ DEFINE_bool(rocksdb_enable_kv_separation,
  "Whether or not to enable BlobDB (RocksDB key-value separation support)");
 
 DEFINE_uint64(rocksdb_kv_separation_threshold,
- 0,
- "RocksDB key value separation threshold. Values at or above this threshold will be "
- "written to blob files during flush or compaction."
+ 100,
+ "RocksDB key value separation threshold in bytes. Values at or above this threshold "
+ "will be written to blob files during flush or compaction."
  "This value is only effective when enable_kv_separation is true.");
 
 DEFINE_string(rocksdb_blob_compression,