Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config about KV separation threshold #3879

Merged
merged 7 commits into from
Feb 16, 2022

Conversation

wenhaocs
Copy link
Contributor

@wenhaocs wenhaocs commented Feb 11, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Per suggestion by @cooper-lzy, we need to give a meaningful default value for KV separation threshold in the config.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@wenhaocs wenhaocs requested a review from a team as a code owner February 11, 2022 01:26
@wenhaocs wenhaocs added cherry-pick-v3.0 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test labels Feb 11, 2022
@Sophie-Xie Sophie-Xie removed the cherry-pick-v3.0 PR: need cherry-pick to this version label Feb 11, 2022
@yixinglu yixinglu merged commit 6975efd into vesoft-inc:master Feb 16, 2022
@Sophie-Xie Sophie-Xie added the doc affected PR: improvements or additions to documentation label Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc affected PR: improvements or additions to documentation ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants