-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring: Move the version info outside the heartbeat request #3055
Labels
incompatible
PR: incompatible with the recently released version
type/enhancement
Type: make the code neat or more efficient
Milestone
Comments
yixinglu
added
type/enhancement
Type: make the code neat or more efficient
incompatible
PR: incompatible with the recently released version
later
and removed
type/feature req
Type: feature request
labels
Oct 13, 2021
7 tasks
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this issue
Mar 21, 2022
#### What type of PR is this? - [ ] bug - [ ] feature - [x] enhancement #### What does this PR do? 1. Move the version info outside the heartbeat 2. Save the version info when establishing the connection to metad server. #### Which issue(s)/PR(s) this PR relates to? vesoft-inc#3055 #### Special notes for your reviewer, ex. impact of this fix, etc: #### Additional context: #### Checklist: - [ ] Documentation affected (Please add the label if documentation needs to be modified.) - [x] Incompatible (If it is incompatible, please describe it and add corresponding label.) - [ ] Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).) - [ ] Performance impacted: Consumes more CPU/Memory #### Release notes: Please confirm whether to reflect in release notes and how to describe: > ` Migrated from vesoft-inc#3378 Co-authored-by: endy.li <25311962+heroicNeZha@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
incompatible
PR: incompatible with the recently released version
type/enhancement
Type: make the code neat or more efficient
Now meta client sends version info in each heartbeat request. That seems not necessary. we could take them when establishing the connection to metad server.
In addition, built-time maybe need to save in meta same as version info. consider to add a new field in request structure to do that.
This refactoring will affect the compatibility of different nebula versions. Do it in next version.
The text was updated successfully, but these errors were encountered: