-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move version info outside of HB #3378
Conversation
why remove the version from heartbeat? to fix any problem? |
it seems not necessary |
Codecov Report
@@ Coverage Diff @@
## master #3378 +/- ##
==========================================
- Coverage 85.27% 85.26% -0.01%
==========================================
Files 1276 1277 +1
Lines 118999 119064 +65
==========================================
+ Hits 101475 101520 +45
- Misses 17524 17544 +20
Continue to review full report at Codecov.
|
Some people remember why there is a version number in their heartbeat? @yixinglu @Aiee @liuyu85cn |
Introduced in this commit |
How to keep the same version between storaged and metad? |
by whitelist in metad: if v2.5.1 and v2.6.1 in whitelist, then they can in same cluster |
Cluster Manager is in progress. |
What type of PR is this?
What does this PR do?
Which issue(s)/PR(s) this PR relates to?
#3055
Special notes for your reviewer, ex. impact of this fix, etc:
Additional context:
Checklist:
Release notes:
Please confirm whether to reflect in release notes and how to describe: