Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move version info outside of HB #3378

Merged
merged 14 commits into from
Dec 7, 2021

Conversation

heroicNeZha
Copy link
Contributor

@heroicNeZha heroicNeZha commented Nov 29, 2021

What type of PR is this?

  • bug
  • feature
  • enhancement

What does this PR do?

  1. Move the version info outside the heartbeat
  2. Save the version info when establishing the connection to metad server.

Which issue(s)/PR(s) this PR relates to?

#3055

Special notes for your reviewer, ex. impact of this fix, etc:

Additional context:

Checklist:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatible (If it is incompatible, please describe it and add corresponding label.)
  • Need to cherry-pick (If need to cherry-pick to some branches, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to reflect in release notes and how to describe:

                                                            `

@darionyaphet
Copy link
Contributor

darionyaphet commented Nov 29, 2021

why remove the version from heartbeat? to fix any problem?

@heroicNeZha
Copy link
Contributor Author

why remove the version from heartbeat? to fix any problem?

it seems not necessary

@heroicNeZha heroicNeZha requested review from yixinglu, panda-sheep and CPWstatic and removed request for yixinglu and panda-sheep November 30, 2021 07:18
@heroicNeZha heroicNeZha added incompatible PR: incompatible with the recently released version ready-for-testing PR: ready for the CI test labels Nov 30, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #3378 (5e5b2a5) into master (fe68b0e) will decrease coverage by 0.00%.
The diff coverage is 96.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3378      +/-   ##
==========================================
- Coverage   85.27%   85.26%   -0.01%     
==========================================
  Files        1276     1277       +1     
  Lines      118999   119064      +65     
==========================================
+ Hits       101475   101520      +45     
- Misses      17524    17544      +20     
Impacted Files Coverage Δ
src/meta/processors/admin/HBProcessor.cpp 92.30% <ø> (-0.38%) ⬇️
src/common/expression/ContainerExpression.cpp 90.00% <66.66%> (-2.13%) ⬇️
src/clients/meta/MetaClient.cpp 76.28% <100.00%> (+0.24%) ⬆️
src/common/utils/MetaKeyUtils.cpp 81.67% <100.00%> (+0.35%) ⬆️
src/graph/validator/test/YieldValidatorTest.cpp 91.78% <100.00%> (ø)
.../processors/admin/VerifyClientVersionProcessor.cpp 100.00% <100.00%> (ø)
src/meta/processors/parts/ListHostsProcessor.cpp 72.54% <100.00%> (+0.40%) ⬆️
src/meta/test/VerifyClientVersionTest.cpp 100.00% <100.00%> (ø)
src/parser/test/ParserTest.cpp 100.00% <100.00%> (ø)
src/meta/processors/parts/GetSpaceProcessor.cpp 60.60% <0.00%> (-18.19%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71c73e1...5e5b2a5. Read the comment docs.

@heroicNeZha heroicNeZha linked an issue Dec 1, 2021 that may be closed by this pull request
src/interface/meta.thrift Outdated Show resolved Hide resolved
@darionyaphet
Copy link
Contributor

Some people remember why there is a version number in their heartbeat? @yixinglu @Aiee @liuyu85cn

@yixinglu
Copy link
Contributor

yixinglu commented Dec 2, 2021

Some people remember why there is a version number in their heartbeat? @yixinglu @Aiee @liuyu85cn

Introduced in this commit

@HarrisChu
Copy link
Contributor

How to keep the same version between storaged and metad?
e.g.
v2.5.1 storaged sends heartbeat to v2.6.1 metad

@heroicNeZha
Copy link
Contributor Author

How to keep the same version between storaged and metad? e.g. v2.5.1 storaged sends heartbeat to v2.6.1 metad

by whitelist in metad: if v2.5.1 and v2.6.1 in whitelist, then they can in same cluster

@darionyaphet
Copy link
Contributor

Cluster Manager is in progress.

@Sophie-Xie Sophie-Xie added ready-for-testing PR: ready for the CI test and removed ready-for-testing PR: ready for the CI test labels Dec 6, 2021
@yixinglu yixinglu merged commit 5194726 into vesoft-inc:master Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible PR: incompatible with the recently released version ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring: Move the version info outside the heartbeat request
9 participants