Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotations for Graph Service #3309

Closed
jackwener opened this issue Nov 11, 2021 · 2 comments · Fixed by #4012
Closed

Annotations for Graph Service #3309

jackwener opened this issue Nov 11, 2021 · 2 comments · Fixed by #4012
Assignees
@jackwener
Labels
type/enhancement Type: make the code neat or more efficient
Milestone
v3.1.0

Comments

@jackwener
Copy link
Contributor

jackwener commented Nov 11, 2021 •
edited
Loading

Introduction

There are few annotations in the project now.

Contents

Add some important or essential annotations for codes.
@jackwener jackwener added type/enhancement Type: make the code neat or more efficient good first issue Community: perfect as the first pull request priority/low-pri Priority: low help wanted Community: does anyone want to work on it? labels Nov 11, 2021
@jamieliu1023 jamieliu1023 mentioned this issue Nov 13, 2021
Closed
@skyguy-netizen
Copy link

Hey! If you still need help, I'd love to contribute!

@jackwener
Copy link
Contributor Author

I would take this task up.

@jackwener jackwener removed good first issue Community: perfect as the first pull request priority/low-pri Priority: low help wanted Community: does anyone want to work on it? labels Jan 14, 2022
@jackwener jackwener changed the title Add more comments to the code Annotations for Graph Service Jan 14, 2022
@jackwener jackwener linked a pull request Jan 14, 2022 that will close this issue
Annotation for Graph Service #3724
Closed
11 tasks
@jackwener jackwener mentioned this issue Jan 14, 2022
Closed
11 tasks
@Sophie-Xie Sophie-Xie moved this from Todo to Coding in Nebula Graph v3.1.0 Feb 8, 2022
@Sophie-Xie Sophie-Xie added this to the v3.0.0 milestone Feb 8, 2022
@Sophie-Xie Sophie-Xie mentioned this issue Feb 8, 2022
Closed
10 tasks
@Sophie-Xie Sophie-Xie modified the milestones: v3.0.0, v3.1.0 Feb 9, 2022
@Sophie-Xie Sophie-Xie moved this from Coding to Reviewing in Nebula Graph v3.1.0 Feb 10, 2022
@jackwener jackwener mentioned this issue Mar 11, 2022
Merged
11 tasks
Repository owner moved this from Reviewing to Done in Nebula Graph v3.1.0 Mar 12, 2022
@jamieliu1023 jamieliu1023 mentioned this issue Mar 19, 2022
Closed
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Mar 21, 2022
@nebula-bots @jackwener
Add annotation (vesoft-inc#677)
db368e2 
<!--
Thanks for your contribution!
In order to review PR more efficiently, please add information according to the template.
-->

#### What type of PR is this?
- [ ] bug
- [ ] feature
- [x] enhancement

#### What problem(s) does this PR solve?
Issue(s) number: close vesoft-inc#3309 

Description:
small fix and add annotation.

#### How do you solve it?


  
#### Special notes for your reviewer, ex. impact of this fix, design document, etc:



#### Checklist:
Tests:
- [ ] Unit test(positive and negative cases)
- [ ] Function test
- [ ] Performance test
- [x] N/A

Affects:
- [ ] Documentation affected (Please add the label if documentation needs to be modified.)
- [ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.）
- [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
- [ ] Performance impacted: Consumes more CPU/Memory


#### Release notes:

Please confirm whether to be reflected in release notes and how to describe:
> ex. Fixed the bug .....


Migrated from vesoft-inc#4012

Co-authored-by: jakevin <30525741+jackwener@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jackwener jackwener

Labels
type/enhancement Type: make the code neat or more efficient
Projects
No open projects
Nebula Graph v3.1.0
Status: Done
Milestone
v3.1.0
Development

Successfully merging a pull request may close this issue.

Add annotation Graph Service jackwener/nebula
Annotation for Graph Service jackwener/nebula
3 participants
@jackwener @skyguy-netizen @Sophie-Xie