Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotation for Graph Service #3724

Closed
wants to merge 8 commits into from
Closed

Conversation

jackwener
Copy link
Contributor

@jackwener jackwener commented Jan 14, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number: close #3309

Description:
small fix and add annotation.

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@jackwener jackwener linked an issue Jan 14, 2022 that may be closed by this pull request
@Aiee
Copy link
Contributor

Aiee commented Jan 17, 2022

@jackwener
Copy link
Contributor Author

Ok, it's fixed.

@jackwener jackwener added the ready-for-testing PR: ready for the CI test label Jan 18, 2022
@jackwener jackwener linked an issue Jan 21, 2022 that may be closed by this pull request
10 tasks
@Sophie-Xie Sophie-Xie requested review from Aiee and jiayuehua February 25, 2022 02:58
jiayuehua
jiayuehua previously approved these changes Feb 28, 2022
Copy link
Contributor

@Aiee Aiee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are lots of uncommented functions like StatusOr<bool> MemoryUtils::hitsHighWatermark() According to google coding practice, every function should be commented.

CPWstatic
CPWstatic previously approved these changes Mar 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Graph code comments & log Annotations for Graph Service
4 participants