-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match query followd by a with clause report alias redefined semantic error (2) #5020
Labels
affects/master
PR/issue: this bug affects master version.
auto-sync
find/automation
process/done
Process of bug
severity/major
Severity of bug
type/bug
Type: something is unexpected
Milestone
Comments
nebula-bots
added
affects/master
PR/issue: this bug affects master version.
auto-sync
find/automation
severity/major
Severity of bug
type/bug
Type: something is unexpected
labels
Dec 7, 2022
11 tasks
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this issue
Jan 31, 2023
<!-- Thanks for your contribution! In order to review PR more efficiently, please add information according to the template. --> ## What type of PR is this? - [X] bug - [ ] feature - [ ] enhancement ## What problem(s) does this PR solve? #### Issue(s) number: Close vesoft-inc#5020 #### Description: The `with *` in a match clause like `match ...(v999)... match ... match ... match ...(v999)... with *` from a multi-match query, where v999 is defined in a previous match, rebuilds named aliases from all query parts, causing v999 to duplicate and trigger a false error. This is actually ok, since they are in fact the same ones. There is actually no redefinition. This compiles with openCypher and neo4j. ## How do you solve it? 1. Allow the usage of aliases defined in previous matches. Only report redefinition of aliases if an alias is repeateed within the current query part. 2. Fixed an unstable tck case. ## Special notes for your reviewer, ex. impact of this fix, design document, etc: ## Checklist: Tests: - [ ] Unit test(positive and negative cases) - [ ] Function test - [ ] Performance test - [X] TCK Affects: - [ ] Documentation affected (Please add the label if documentation needs to be modified.) - [ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.) - [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).) - [ ] Performance impacted: Consumes more CPU/Memory ## Release notes: Please confirm whether to be reflected in release notes and how to describe: > ex. Fixed the bug ..... Migrated from vesoft-inc#5021 Co-authored-by: Cheng Xuntao <7731943+xtcyclist@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
affects/master
PR/issue: this bug affects master version.
auto-sync
find/automation
process/done
Process of bug
severity/major
Severity of bug
type/bug
Type: something is unexpected
Please check the FAQ documentation before raising an issue
Describe the bug (required)
A similar problem to #1579 but with a different query and even though we have applied the fix of #1579 (tested on latest community master branch), the query below still report a Redefined alias error:
In contrast the same query on Neo4j report no error:
Your Environments (required)
uname -a
g++ --version
orclang++ --version
lscpu
a3ffc7d8
) https://github.com/vesoft-inc/nebula/tree/611c6705f9ef57c2f21104dabf9c3b59d45d1e65How To Reproduce(required)
Steps to reproduce the behavior:
Expected behavior
Additional context
The text was updated successfully, but these errors were encountered: