Fixed linking error with gold #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutor
requested review from
monadbobo,
yixinglu,
CPWstatic,
critical27,
dangleptr and
laura-ding
|
I think the error was due to the linker option To be specific, with |
|
Unit testing passed. |
|
Unit testing passed. |
dangleptr
approved these changes
Jan 3, 2020
|
Awesome |
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
When using gold as the linker, building fails with undefined referenced symbols. As for the the reason underhood, I will dig it later. I think the error was due to the linker option --gc-sections, which is enabled with ld.bfd, mostly the default one, while disabled with ld.gold. To be specific, with --gc-sections, some unused functions are eliminated during the link stage(this is one of several ways I reduce the build size), as well as their dependencies. At the meantime, --gc-sections is disabled when gold linker is used, since it's buggy when they are used together(something tedious on use of systemtap by folly, ignore it if no interest, consult me otherwise).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using gold as the linker, building fails with undefined referenced symbols. As for the the reason underhood, I will dig it later.