Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[nGQL] parser bug for minus 1 #563

Closed
whitewum opened this issue Jul 1, 2019 · 2 comments · Fixed by #429
Closed

[nGQL] parser bug for minus 1 #563

whitewum opened this issue Jul 1, 2019 · 2 comments · Fixed by #429
Milestone
R201910_beta

Comments

@whitewum
Copy link
Contributor

whitewum commented Jul 1, 2019

nebula> GO FROM 100 OVER like YIELD like._dst -1 as ret1 [ERROR (-7)]: syntax error near `-1' nebula> GO FROM 100 OVER like YIELD like._dst - 1 as ret1 ======== | ret1 | ======== | 100 | -------- Got 1 rows (Time spent: 1675/2524 us)

-1 vs. -1 1
@laura-ding laura-ding mentioned this issue Jul 1, 2019
Merged
@whitewum
Copy link
Contributor Author

whitewum commented Jul 1, 2019

@laura-ding if u close this bug, please make there is a unit test directly cover this situation.
please help & check it for me.

@whitewum
Copy link
Contributor Author

whitewum commented Jul 1, 2019

@dutor please help to add a ut.

@sherman-the-tank sherman-the-tank added this to the v1_beta_release milestone Jul 1, 2019
@dutor dutor closed this as completed in #429 Jul 2, 2019
yixinglu pushed a commit to yixinglu/nebula that referenced this issue Mar 21, 2022
@nebula-bots @cangfengzhs
put dataVersionKey on create space for storage (vesoft-inc#563)
c286996 
<!--
Thanks for your contribution!
In order to review PR more efficiently, please add information according to the template.
-->

#### What type of PR is this?
- [x] bug
- [ ] feature
- [ ] enhancement

#### What problem(s) does this PR solve?
Issue(s) number: 
close vesoft-inc#3777 
Description:
Put dataVersionKey when create space

#### How do you solve it?


  
#### Special notes for your reviewer, ex. impact of this fix, design document, etc:



#### Checklist:
Tests:
- [ ] Unit test(positive and negative cases)
- [ ] Function test
- [ ] Performance test
- [ ] N/A

Affects:
- [ ] Documentation affected (Please add the label if documentation needs to be modified.)
- [ ] Incompatibility (If it breaks the compatibility, please describe it and add the label.）
- [ ] If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
- [ ] Performance impacted: Consumes more CPU/Memory


#### Release notes:

Please confirm whether to be reflected in release notes and how to describe:
> ex. Fixed the bug .....


Migrated from vesoft-inc#3817

Co-authored-by: hs.zhang <22708345+cangfengzhs@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
R201910_beta
Development

Successfully merging a pull request may close this issue.

Fixed unary minus integer bug and support to take function call as vid
2 participants
@sherman-the-tank @whitewum