-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed unary minus integer bug and support to take function call as vid #429
Conversation
Unit testing failed. |
Unit testing passed. |
Unit testing failed. |
remember add to nGQL.md after check in |
@@ -403,7 +410,7 @@ TEST(Parser, InsertEdge) { | |||
{ | |||
GQLParser parser; | |||
std::string query = "INSERT EDGE NO OVERWRITE transfer(amount, time) " | |||
"VALUES 12345->54321@1537408527:(3.75, 1537408527)"; | |||
"VALUES 12345->-54321@1537408527:(3.75, 1537408527)"; | |||
auto result = parser.parse(query); | |||
ASSERT_TRUE(result.ok()) << result.status(); | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try -1->-2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's your point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a negtive vid to another negtive vid. recommend to cover this simple situation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Unit testing passed. |
1 similar comment
Unit testing passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well done
close #563 |
src/graph/GoExecutor.cpp
Outdated
// (Even though we already implicitly add `YIELD edge_type._dst AS id`) | ||
// In such case, the input ref could be simply written as `$-'. | ||
// TODO(dutor) In future, we should remove the implicitly added YIELD clause. | ||
static const std::string defaultCol("id"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about giving this default in parser, like this:
| INPUT_REF {
auto *label = new std::string("id");
$$ = new InputPropertyExpression(label);
}
src/common/filter/Expressions.cpp
Outdated
@@ -138,7 +138,8 @@ Expression::decode(folly::StringPiece buffer) noexcept { | |||
std::string InputPropertyExpression::toString() const { | |||
std::string buf; | |||
buf.reserve(64); | |||
buf += "$-."; | |||
buf += "$-"; | |||
buf += "."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check out this.
Jenkins, go! |
Unit testing passed. |
vesoft-inc#429) * Fixed unary minus integer bug and support to take function call as vid * Fixed crash when a non-existing column referenced in PIPE * Addressed @laura-ding's comment * minor fixes * add test for unary minus * Address comments * Addressed @CPWstatic's comments
vesoft-inc#429) * Fixed unary minus integer bug and support to take function call as vid * Fixed crash when a non-existing column referenced in PIPE * Addressed @laura-ding's comment * minor fixes * add test for unary minus * Address comments * Addressed @CPWstatic's comments
vesoft-inc#429) * Fixed unary minus integer bug and support to take function call as vid * Fixed crash when a non-existing column referenced in PIPE * Addressed @laura-ding's comment * minor fixes * add test for unary minus * Address comments * Addressed @CPWstatic's comments
* add db-upgrade V3 * use ingest * modify upgrade args * write data version key * address wenhao's comment * address some comment * address some comment * format Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> Co-authored-by: hs.zhang <22708345+cangfengzhs@users.noreply.github.com> Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
As title.
Now, you can use function call expression where a vertex id is required, like
INSERT VERTEX player(name, age) VALUES hash("Tim Duncan"): ("Tim Duncan", 42)
close #563