Fixed unary minus integer bug and support to take function call as vid #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dutor
requested review from
ayyt,
sherman-the-tank,
dangleptr,
boshengchen and
laura-ding
laura-ding
reviewed
May 29, 2019
|
Unit testing failed. |
|
Unit testing passed. |
|
Unit testing failed. |
|
remember add to nGQL.md after check in |
whitewum
previously approved these changes
Jun 20, 2019
| @@ -403,7 +410,7 @@ TEST(Parser, InsertEdge) { | |||
| { | |||
| GQLParser parser; | |||
| std::string query = "INSERT EDGE NO OVERWRITE transfer(amount, time) " | |||
| "VALUES 12345->54321@1537408527:(3.75, 1537408527)"; | |||
| "VALUES 12345->-54321@1537408527:(3.75, 1537408527)"; | |||
| auto result = parser.parse(query); | |||
| ASSERT_TRUE(result.ok()) << result.status(); | |||
| } | |||
There was a problem hiding this comment.
a negtive vid to another negtive vid. recommend to cover this simple situation.
|
Unit testing passed. |
1 similar comment
|
Unit testing passed. |
|
close #563 |
CPWstatic
reviewed
Jul 1, 2019
src/graph/GoExecutor.cpp
Outdated
| // (Even though we already implicitly add `YIELD edge_type._dst AS id`) | ||
| // In such case, the input ref could be simply written as `$-'. | ||
| // TODO(dutor) In future, we should remove the implicitly added YIELD clause. | ||
| static const std::string defaultCol("id"); |
There was a problem hiding this comment.
How about giving this default in parser, like this:
| INPUT_REF {
auto *label = new std::string("id");
$$ = new InputPropertyExpression(label);
}
CPWstatic
reviewed
Jul 1, 2019
src/common/filter/Expressions.cpp
Outdated
| @@ -138,7 +138,8 @@ Expression::decode(folly::StringPiece buffer) noexcept { | |||
| std::string InputPropertyExpression::toString() const { | |||
| std::string buf; | |||
| buf.reserve(64); | |||
| buf += "$-."; | |||
| buf += "$-"; | |||
| buf += "."; | |||
CPWstatic
approved these changes
Jul 2, 2019
laura-ding
approved these changes
Jul 2, 2019
|
Jenkins, go! |
|
Unit testing passed. |
dangleptr
pushed a commit
to dangleptr/nebula
that referenced
this pull request
Jul 5, 2019
vesoft-inc#429) * Fixed unary minus integer bug and support to take function call as vid * Fixed crash when a non-existing column referenced in PIPE * Addressed @laura-ding's comment * minor fixes * add test for unary minus * Address comments * Addressed @CPWstatic's comments
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Feb 16, 2020
vesoft-inc#429) * Fixed unary minus integer bug and support to take function call as vid * Fixed crash when a non-existing column referenced in PIPE * Addressed @laura-ding's comment * minor fixes * add test for unary minus * Address comments * Addressed @CPWstatic's comments
tong-hao
pushed a commit
to tong-hao/nebula
that referenced
this pull request
Jun 1, 2021
vesoft-inc#429) * Fixed unary minus integer bug and support to take function call as vid * Fixed crash when a non-existing column referenced in PIPE * Addressed @laura-ding's comment * minor fixes * add test for unary minus * Address comments * Addressed @CPWstatic's comments
yixinglu
pushed a commit
to yixinglu/nebula
that referenced
this pull request
Mar 21, 2022
* add db-upgrade V3 * use ingest * modify upgrade args * write data version key * address wenhao's comment * address some comment * address some comment * format Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> Co-authored-by: hs.zhang <22708345+cangfengzhs@users.noreply.github.com> Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
Now, you can use function call expression where a vertex id is required, like
INSERT VERTEX player(name, age) VALUES hash("Tim Duncan"): ("Tim Duncan", 42)close #563