Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] add glog curl command #1235

Merged
merged 4 commits into from
Nov 21, 2019
Merged

[doc] add glog curl command #1235

merged 4 commits into from
Nov 21, 2019

Conversation

whitewum
Copy link
Contributor

@whitewum whitewum commented Nov 7, 2019

change v & minloglevel at runtime by http command curl.

It is quit useful for on-site debuging

@Amber1990Zhang help to change to Eng and add to readme.md TOC.

@amber-moe amber-moe mentioned this pull request Nov 8, 2019
Merged
amber-moe
amber-moe reviewed Nov 8, 2019
View reviewed changes
Copy link
Contributor

@amber-moe amber-moe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this, English version see #1237

...istration/3.deploy-and-administrations/server-administration/configuration-statements/log.md Outdated Show resolved Hide resolved
...istration/3.deploy-and-administrations/server-administration/configuration-statements/log.md Outdated Show resolved Hide resolved
...istration/3.deploy-and-administrations/server-administration/configuration-statements/log.md Outdated Show resolved Hide resolved
...istration/3.deploy-and-administrations/server-administration/configuration-statements/log.md Show resolved Hide resolved
...istration/3.deploy-and-administrations/server-administration/configuration-statements/log.md Outdated Show resolved Hide resolved
@whitewum whitewum added the do not review PR: not ready for the code review yet label Nov 11, 2019
@whitewum whitewum removed the do not review PR: not ready for the code review yet label Nov 11, 2019
amber-moe
amber-moe reviewed Nov 12, 2019
View reviewed changes
...istration/3.deploy-and-administrations/server-administration/configuration-statements/log.md Outdated
> curl "http://127.0.0.1:12000/set_flags?flag=minloglevel&value=0"
```

或者**关闭** 所有的日志打印(仅保留 FATAL)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove extra space

amber-moe
amber-moe reviewed Nov 12, 2019
View reviewed changes
...istration/3.deploy-and-administrations/server-administration/configuration-statements/log.md Outdated

### glog 中的两个主要参数

- minloglevel 0-4： 对应的日志级别分别为 INFO(DEBUG)，WARING，ERROR，FATAL。通常在调试环境设置为 0，生产环境设置为1。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space missing before 1

@whitewum whitewum force-pushed the glog-doc branch 2 times, most recently from 23e9b80 to a04862c Compare November 12, 2019 12:20
@whitewum
Copy link
Contributor Author

why the toc is updated, but this pr is not merged?
I think we should mention some pr depends on other pr

jude-zhu
jude-zhu reviewed Nov 18, 2019
View reviewed changes
...istration/3.deploy-and-administrations/server-administration/configuration-statements/log.md Outdated

### glog 中的两个主要参数

- minloglevel 0-4： 对应的日志级别分别为 INFO(DEBUG)，WARING，ERROR，FATAL。通常在调试环境设置为 0，生产环境设置为 1。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minloglevel 0-3? numbers of severity levels INFO, WARNING, ERROR, and FATAL are 0, 1, 2, and 3, respectively

refer to https://github.com/google/glog/blob/master/src/glog/log_severity.h

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@critical27 please help check

Copy link
Contributor

@critical27 critical27 Nov 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the minloglevel 0-3 is INFO, WARNING, ERROR, FALAL respectively. And the v is valid only when minloglevel is 0 (It used for debug by printing more detailed log). If minloglevel >=4, no log at all.

Copy link
Contributor

@critical27 critical27 Nov 18, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, WARING is a typo.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your reply, please help update this. @whitewum

critical27
critical27 reviewed Nov 19, 2019
View reviewed changes
Copy link
Contributor

@critical27 critical27 left a comment •
edited by whitewum
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will support change minloglevel, v in #1273, do we still need this doc?

currenty，I'll use the doc.

we can delete it in the next release.

@whitewum whitewum mentioned this pull request Nov 20, 2019
Merged
@jude-zhu jude-zhu added the ready-for-testing PR: ready for the CI test label Nov 20, 2019
@jude-zhu
Copy link
Contributor

Jenkins go

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit e36579f into vesoft-inc:master Nov 21, 2019
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@whitewum @dutor
[doc] add glog curl command (vesoft-inc#1235)
c783924 
* add glog chs

* address amber's comment

* address critical's comment
@yixinglu yixinglu mentioned this pull request Aug 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@critical27 critical27 critical27 left review comments

@amber-moe amber-moe amber-moe approved these changes

@jude-zhu jude-zhu jude-zhu approved these changes

@jievince jievince Awaiting requested review from jievince

@laura-ding laura-ding Awaiting requested review from laura-ding

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@whitewum @jude-zhu @nebula-community-bot @critical27 @amber-moe @dutor