Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support expression in update configs #1273

Merged
merged 11 commits into from
Nov 25, 2019
Merged

support expression in update configs #1273

merged 11 commits into from
Nov 25, 2019

Conversation

critical27
Copy link
Contributor

@critical27 critical27 commented Nov 15, 2019 •
edited
Loading

  1. Support expression in update configs, e.g.
    update configs storage:rocksdb_column_family_options={ target_file_size_base=100*1024*1024 }
  2. Temporarily forbid modify write_buffer_size in update configs, it would cause rocksdb crash. Remove some configs which can't be set dynamically.
  3. Remove some unused Status.
  4. Support some mutable configs in console, such as minlevel, v, etc.

@critical27 critical27 added the ready-for-testing PR: ready for the CI test label Nov 15, 2019
@nebula-community-bot
Copy link
Member

Unit testing failed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

bright-starry-sky
bright-starry-sky reviewed Nov 16, 2019
View reviewed changes
src/parser/MutateSentences.cpp
return Status::Error("Invalid string config value");
}

buf += Expression::toString(ret.value());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like this ！

@amber-moe amber-moe mentioned this pull request Nov 19, 2019
Merged
@nebula-community-bot
Copy link
Member

Unit testing passed.

1 similar comment
@nebula-community-bot
Copy link
Member

Unit testing passed.

darionyaphet
darionyaphet previously approved these changes Nov 19, 2019
View reviewed changes
@nebula-community-bot
Copy link
Member

Unit testing passed.

darionyaphet
darionyaphet previously approved these changes Nov 20, 2019
View reviewed changes
@nebula-community-bot
Copy link
Member

Unit testing passed.

@whitewum
Copy link
Contributor

Changing the log level is the most frequently used command. Definitely, we should provide a document about this operation.

could you give an example doc. So I can abandon #1235

@critical27
Copy link
Contributor Author

critical27 commented Nov 20, 2019 •
edited
Loading

Changing the log level is the most frequently used command. Definitely, we should provide a document about this operation.

could you give an example doc. So I can abandon #1235

Maybe we can still keep #1235, because if user have run meta before, it will register configs of minloglevel as immutable, we still can't update it in console unless clear data on meta.

Anyway, I'll give a brief sample of update minloglevel in console to @Amber1990Zhang

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing failed.

@critical27
Copy link
Contributor Author

Jenkins go

@nebula-community-bot
Copy link
Member

Unit testing passed.

darionyaphet
darionyaphet approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@darionyaphet darionyaphet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ~

bright-starry-sky
bright-starry-sky approved these changes Nov 22, 2019
View reviewed changes
Copy link
Contributor

@bright-starry-sky bright-starry-sky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good job!

@nebula-community-bot
Copy link
Member

Unit testing passed.

@nebula-community-bot
Copy link
Member

Unit testing passed.

@dutor dutor merged commit 8d28674 into vesoft-inc:master Nov 25, 2019
@critical27 critical27 deleted the rocks-option branch November 25, 2019 05:43
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Feb 16, 2020
@critical27 @dutor
support expression in update configs (vesoft-inc#1273)
1c38815 
* support expression in update configs

* fix ut

* Return error of string option

* remove some rocksdb configs, support change more configs in console

* remove change in default template

* fix ut

* update gflags.json
tong-hao pushed a commit to tong-hao/nebula that referenced this pull request Jun 1, 2021
@critical27 @dutor
support expression in update configs (vesoft-inc#1273)
353b075 
* support expression in update configs

* fix ut

* Return error of string option

* remove some rocksdb configs, support change more configs in console

* remove change in default template

* fix ut

* update gflags.json
yixinglu pushed a commit to yixinglu/nebula that referenced this pull request Jan 31, 2023
@nebula-bots @SuperYoko
Add meta offline detect (vesoft-inc#1273)
afc50b5 
* Add meta offline detect

* fix conflict

Co-authored-by: Alex Xing <90179377+SuperYoko@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darionyaphet darionyaphet darionyaphet approved these changes

@bright-starry-sky bright-starry-sky bright-starry-sky approved these changes

@yixinglu yixinglu Awaiting requested review from yixinglu

@CPWstatic CPWstatic Awaiting requested review from CPWstatic

@dangleptr dangleptr Awaiting requested review from dangleptr

@laura-ding laura-ding Awaiting requested review from laura-ding

@liuyu85cn liuyu85cn Awaiting requested review from liuyu85cn

Assignees
No one assigned
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@critical27 @nebula-community-bot @whitewum @darionyaphet @bright-starry-sky @dutor