Fix storage core when exit #3050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
critical27
requested review from
darionyaphet,
cangfengzhs,
liwenhui-soul,
liuyu85cn,
bright-starry-sky,
panda-sheep,
SuperYoko and
pengweisong
critical27
added
ready-for-testing
liwenhui-soul
previously approved these changes
Oct 13, 2021
|
The reason has been updated in #3049 |
liwenhui-soul
approved these changes
Oct 15, 2021
darionyaphet
approved these changes
Oct 15, 2021
| @@ -195,6 +195,9 @@ void AdminTaskManager::shutdown() { | |||
| if (unreportedAdminThread_ != nullptr) { | |||
| unreportedAdminThread_->join(); | |||
| } | |||
| if (env_) { | |||
| env_->adminStore_.reset(); | |||
There was a problem hiding this comment.
why don't stop() it before reset()
There was a problem hiding this comment.
It is ok, when rocksdb is released, it will call the CancelBackgroundJob in rocksdb as well
Sophie-Xie
pushed a commit
that referenced
this pull request
Oct 18, 2021
* although I don't have time to check why it works, but this do fix the issue * fix ut
CPWstatic
pushed a commit
that referenced
this pull request
Oct 19, 2021
* Pass graph profile param into storage and cleanup graph storage client interfaces (#3026) * Cleanup graph storage client interfaces * Fix compile * Format * Fix shadow compile error * Fix storage core when exit (#3050) * although I don't have time to check why it works, but this do fix the issue * fix ut * Accumulate toss bug fix during test. (#3091) * add some debug info * accumulate bug fix for TOSS Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> * Support more validation when create space on an empty zone (#3065) Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com> Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> * small tck fix (#3087) Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com> * cascading deletion and addition (#3059) Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> * fix toss switch not set properly (#3119) Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com> Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com> Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> Co-authored-by: lionel.liu@vesoft.com <52276794+liuyu85cn@users.noreply.github.com> Co-authored-by: yaphet <4414314+darionyaphet@users.noreply.github.com> Co-authored-by: kyle.cao <kyle.cao@vesoft.com> Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't check it throughly, wait @liwenhui-soul to figure out.
Close #3049