Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small tck fix #3087

Merged
merged 4 commits into from
Oct 18, 2021
Merged

small tck fix #3087

merged 4 commits into from
Oct 18, 2021

Conversation

czpmango
Copy link
Contributor

@czpmango czpmango commented Oct 15, 2021

Just replace the actual constant relation_type id with a regex expression to avoid possible CI error.

@czpmango czpmango added the ready-for-testing PR: ready for the CI test label Oct 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2021

Codecov Report

Merging #3087 (e0e4878) into master (fb3be74) will increase coverage by 0.74%.
The diff coverage is 94.78%.

❗ Current head e0e4878 differs from pull request most recent head 63ab756. Consider uploading reports for the commit 63ab756 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3087      +/-   ##
==========================================
+ Coverage   84.30%   85.04%   +0.74%     
==========================================
  Files        1287     1287              
  Lines      115636   115675      +39     
==========================================
+ Hits        97483    98373     +890     
+ Misses      18153    17302     -851     
Impacted Files Coverage Δ
src/clients/storage/GraphStorageClient.cpp 76.19% <92.20%> (+0.10%) ⬆️
src/clients/storage/GraphStorageClient.h 100.00% <100.00%> (ø)
src/graph/executor/mutate/DeleteExecutor.cpp 83.22% <100.00%> (+0.33%) ⬆️
src/graph/executor/mutate/InsertExecutor.cpp 100.00% <100.00%> (ø)
src/graph/executor/mutate/UpdateExecutor.cpp 87.64% <100.00%> (+0.89%) ⬆️
src/graph/executor/query/GetEdgesExecutor.cpp 94.00% <100.00%> (+0.12%) ⬆️
src/graph/executor/query/GetNeighborsExecutor.cpp 97.10% <100.00%> (+0.04%) ⬆️
src/graph/executor/query/GetVerticesExecutor.cpp 96.77% <100.00%> (+0.10%) ⬆️
src/graph/executor/query/IndexScanExecutor.cpp 88.88% <100.00%> (ø)
src/graph/service/QueryEngine.cpp 96.96% <100.00%> (ø)
... and 79 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55ed186...63ab756. Read the comment docs.

@yixinglu yixinglu merged commit b18dbdd into vesoft-inc:master Oct 18, 2021
Sophie-Xie pushed a commit that referenced this pull request Oct 18, 2021
Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com>
CPWstatic pushed a commit that referenced this pull request Oct 19, 2021
* Pass graph profile param into storage and cleanup graph storage client interfaces (#3026)

* Cleanup graph storage client interfaces

* Fix compile

* Format

* Fix shadow compile error

* Fix storage core when exit (#3050)

* although I don't have time to check why it works, but this do fix the issue

* fix ut

* Accumulate toss bug fix during test. (#3091)

* add some debug info

* accumulate bug fix for TOSS

Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>

* Support more validation when create space on an empty zone (#3065)

Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>

* small tck fix (#3087)

Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com>

* cascading deletion and addition (#3059)

Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>

* fix toss switch not set properly (#3119)

Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>

Co-authored-by: Yee <2520865+yixinglu@users.noreply.github.com>
Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Co-authored-by: lionel.liu@vesoft.com <52276794+liuyu85cn@users.noreply.github.com>
Co-authored-by: yaphet <4414314+darionyaphet@users.noreply.github.com>
Co-authored-by: kyle.cao <kyle.cao@vesoft.com>
Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants