-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Raft] fix some remaining problems after pre-vote merged #3415
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3415 +/- ##
==========================================
- Coverage 85.24% 77.80% -7.44%
==========================================
Files 1278 1278
Lines 119200 119289 +89
==========================================
- Hits 101608 92817 -8791
- Misses 17592 26472 +8880
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I'll do more test together with the following raft pr.
I am reviewing current implementation, some issues are found:
lastLogId_ != wal_->lastLogId()
.lastLogId_ < committedLogId_
, only lastLogId_ is set to committedLogId_.And some minor changes, set
leader_
whenever term changed, this is a prepare for later AppendLogs refactor.