Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash of null path expression. #3915

Merged
merged 4 commits into from
Feb 21, 2022
Merged

Fix crash of null path expression. #3915

merged 4 commits into from
Feb 21, 2022

Conversation

Shylock-Hg
Copy link
Contributor

@Shylock-Hg Shylock-Hg commented Feb 18, 2022 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Close #3914

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Shylock-Hg Shylock-Hg added the type/bug Type: something is unexpected label Feb 18, 2022
@Shylock-Hg Shylock-Hg marked this pull request as ready for review February 18, 2022 08:32
@Shylock-Hg Shylock-Hg added the ready-for-testing PR: ready for the CI test label Feb 18, 2022
@CPWstatic CPWstatic merged commit fdcaa0a into vesoft-inc:master Feb 21, 2022
@Shylock-Hg Shylock-Hg deleted the fix/crash-null-path-expr branch February 21, 2022 09:56
@Sophie-Xie Sophie-Xie added the cherry-pick-v3.0 PR: need cherry-pick to this version label Feb 24, 2022
@jamieliu1023 jamieliu1023 mentioned this pull request Feb 26, 2022
Closed
Sophie-Xie pushed a commit that referenced this pull request Mar 11, 2022
@Shylock-Hg @jackwener @Sophie-Xie
Fix crash of null path expression. (#3915)
914f8c3 
* Fix crash of null path expression.

* Add test case.

Co-authored-by: jakevin <30525741+jackwener@users.noreply.github.com>
CPWstatic pushed a commit that referenced this pull request Mar 14, 2022
@Sophie-Xie @panda-sheep
@Shylock-Hg @jackwener @Aiee
Cherry pick v3.0.1 (#4007)
d523376 
* fix fix 0 file error (#3920)

* Fix crash of null path expression. (#3915)

* Fix crash of null path expression.

* Add test case.

Co-authored-by: jakevin <30525741+jackwener@users.noreply.github.com>

* Change the name of source code zip (#3999)

* Fix service crash caused by connecting using a pre-v2.6.0 client (#3942)

* Reject clients with a version lower than 2.6.0

* Add TTL for clientAddr_

* Fix tests

* Use client_idle_timeout_secs as the clientAddrTimeout

* Change the param of authCheckFromCache()

Co-authored-by: panda-sheep <59197347+panda-sheep@users.noreply.github.com>
Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com>
Co-authored-by: jakevin <30525741+jackwener@users.noreply.github.com>
Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CPWstatic CPWstatic CPWstatic approved these changes

@Aiee Aiee Aiee approved these changes

@jackwener jackwener jackwener approved these changes

@czpmango czpmango Awaiting requested review from czpmango

Assignees
No one assigned
Labels
cherry-pick-v3.0 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test type/bug Type: something is unexpected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unsupported query.
5 participants
@Shylock-Hg @CPWstatic @Aiee @jackwener @Sophie-Xie