Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ingest 0 file error in upgrade tool 3.0 #3920

Merged
merged 2 commits into from
Feb 22, 2022

Conversation

panda-sheep
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

fix upgrade tool 3.0,
When there is no tag under the space, the upgrade tool core.
coredump as follows:

I20220221 15:28:40.337662 281523 DbUpgrader.cpp:1081] Copy space id 133 wal file begin
I20220221 15:28:40.548403 281523 DbUpgrader.cpp:1228] Copy space id 133 wal file success
I20220221 15:28:40.548442 281523 DbUpgrader.cpp:1072] Path /data/nebula/storaged_backup space id 133 compaction begin
E20220221 15:28:41.543736 281518 RocksEngine.cpp:426] Ingest Failed: Invalid argument: external_files[0] is empty
F20220221 15:28:41.543795 281518 DbUpgrader.cpp:996] Faild upgrade 2:3 when ingest sst file:-8000
*** Check failure stack trace: ***
*** Aborted at 1645428522 (Unix time, try 'date -d @1645428522') ***
*** Signal 6 (SIGABRT) (0x449aa) received by PID 281002 (pthread TID 0x7f8c679ff700) (linux TID 281518) (maybe from PID 281002, UID 0) (code: -6), stack trace: ***
./nebula-graph-3.0.0.el7.x86_64/bin/db_upgrader(_ZN5folly10symbolizer17getStackTraceSafeEPmm+0x31)[0x24ca151]
./nebula-graph-3.0.0.el7.x86_64/bin/db_upgrader(_ZN5folly10symbolizer21SafeStackTracePrinter15printStackTraceEb+0x26)[0x24c1656]
./nebula-graph-3.0.0.el7.x86_64/bin/db_upgrader[0x24bf5e7]
/lib64/libpthread.so.0(+0xf5df)[0x7f8c7da795df]
/lib64/libc.so.6(gsignal+0x37)[0x7f8c7d6dc1f7]
/lib64/libc.so.6(abort+0x147)[0x7f8c7d6dd8e7]
./nebula-graph-3.0.0.el7.x86_64/bin/db_upgrader[0x24f2e59]
./nebula-graph-3.0.0.el7.x86_64/bin/db_upgrader[0x24f5f53]
./nebula-graph-3.0.0.el7.x86_64/bin/db_upgrader[0x24f2928]
./nebula-graph-3.0.0.el7.x86_64/bin/db_upgrader[0x24f6608]
./nebula-graph-3.0.0.el7.x86_64/bin/db_upgrader(_ZN6nebula7storage13UpgraderSpace11doProcessV3Ev+0x317)[0x1101f37]
./nebula-graph-3.0.0.el7.x86_64/bin/db_upgrader(_ZN6nebula7storage10DbUpgrader7doSpaceEv+0x191)[0x11099f1]
./nebula-graph-3.0.0.el7.x86_64/bin/db_upgrader(_ZN5folly18ThreadPoolExecutor7runTaskERKSt10shared_ptrINS0_6ThreadEEONS0_4TaskE+0x137)[0x24098f7]
./nebula-graph-3.0.0.el7.x86_64/bin/db_upgrader[0x23fc10e]
./nebula-graph-3.0.0.el7.x86_64/bin/db_upgrader(_ZN5folly9EventBase20FunctionLoopCallback15runLoopCallbackEv+0xa)[0x2473d6a]
./nebula-graph-3.0.0.el7.x86_64/bin/db_upgrader(_ZN5folly9EventBase16runLoopCallbacksERN5boost9intrusive4listINS0_12LoopCallbackEJNS2_18constant_time_sizeILb0EEEEEE+0x109)[0x246c959]
./nebula-graph-3.0.0.el7.x86_64/bin/db_upgrader(_ZN5folly9EventBase16runLoopCallbacksEv+0x86)[0x246c9e6]
./nebula-graph-3.0.0.el7.x86_64/bin/db_upgrader(_ZN5folly9EventBase8loopBodyEib+0x1d2)[0x246ec92]
./nebula-graph-3.0.0.el7.x86_64/bin/db_upgrader(_ZN5folly9EventBase4loopEv+0x3d)[0x246f81d]
./nebula-graph-3.0.0.el7.x86_64/bin/db_upgrader(_ZN5folly9EventBase11loopForeverEv+0x17)[0x2472457]
./nebula-graph-3.0.0.el7.x86_64/bin/db_upgrader(_ZN5folly20IOThreadPoolExecutor9threadRunESt10shared_ptrINS_18ThreadPoolExecutor6ThreadEE+0x338)[0x23fcaf8]
./nebula-graph-3.0.0.el7.x86_64/bin/db_upgrader(_ZN5folly6detail8function14FunctionTraitsIFvvEE7callBigISt5_BindIFMNS_18ThreadPoolExecutorEFvSt10shared_ptrINS7_6ThreadEEEPS7_SA_EEEEvRNS1_4DataE+0x46)[0x240b066]
./nebula-graph-3.0.0.el7.x86_64/bin/db_upgrader[0x2a1fe9f]
/lib64/libpthread.so.0(+0x7e24)[0x7f8c7da71e24]
/lib64/libc.so.6(clone+0x6c)[0x7f8c7d79f34c]
(safe mode, symbolizer not available)
Aborted
You have mail in /var/spool/mail/root

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@panda-sheep panda-sheep changed the title fix fix 0 file error fix ingest 0 file error in upgrade tool 3.0 Feb 21, 2022
@panda-sheep panda-sheep added ready for review ready-for-testing PR: ready for the CI test labels Feb 21, 2022
@critical27 critical27 merged commit 7764aed into vesoft-inc:master Feb 22, 2022
@panda-sheep panda-sheep deleted the fix_upgrade_v3.0 branch February 22, 2022 03:40
Sophie-Xie pushed a commit that referenced this pull request Mar 11, 2022
CPWstatic pushed a commit that referenced this pull request Mar 14, 2022
* fix fix 0 file error (#3920)

* Fix crash of null path expression. (#3915)

* Fix crash of null path expression.

* Add test case.

Co-authored-by: jakevin <30525741+jackwener@users.noreply.github.com>

* Change the name of source code zip (#3999)

* Fix service crash caused by connecting using a pre-v2.6.0 client (#3942)

* Reject clients with a version lower than 2.6.0

* Add TTL for clientAddr_

* Fix tests

* Use client_idle_timeout_secs as the clientAddrTimeout

* Change the param of authCheckFromCache()

Co-authored-by: panda-sheep <59197347+panda-sheep@users.noreply.github.com>
Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com>
Co-authored-by: jakevin <30525741+jackwener@users.noreply.github.com>
Co-authored-by: Yichen Wang <18348405+Aiee@users.noreply.github.com>
@Sophie-Xie Sophie-Xie added the cherry-pick-v3.0 PR: need cherry-pick to this version label Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.0 PR: need cherry-pick to this version ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants