Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update error message when connect with an out-of-date client #4021

Merged
merged 3 commits into from
Mar 14, 2022
Merged

Update error message when connect with an out-of-date client #4021

merged 3 commits into from
Mar 14, 2022

Conversation

Aiee
Copy link
Contributor

@Aiee Aiee commented Mar 14, 2022 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

This PR fixes some problems in 3.0.0 version:

  1. To make the version incompatible message clearer.
  2. Do client version check before FLAGS_enable_authorize check

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@Aiee Aiee added ready-for-testing PR: ready for the CI test ready for review labels Mar 14, 2022
@Aiee Aiee requested a review from HarrisChu March 14, 2022 07:21
HarrisChu
HarrisChu previously approved these changes Mar 14, 2022
View reviewed changes
jievince
jievince previously approved these changes Mar 14, 2022
View reviewed changes
@Sophie-Xie Sophie-Xie added the cherry-pick-v3.0 PR: need cherry-pick to this version label Mar 14, 2022
yixinglu
yixinglu previously approved these changes Mar 14, 2022
View reviewed changes
czpmango
czpmango previously approved these changes Mar 14, 2022
View reviewed changes
@Aiee Aiee dismissed stale reviews from czpmango, yixinglu, jievince, and HarrisChu via b134868 March 14, 2022 10:19
@Aiee Aiee force-pushed the update-errorMsg branch from 3c63749 to b134868 Compare March 14, 2022 10:19
@Aiee Aiee requested review from yixinglu and HarrisChu March 14, 2022 10:20
@Sophie-Xie Sophie-Xie merged commit 36c15b2 into vesoft-inc:master Mar 14, 2022
@Aiee Aiee deleted the update-errorMsg branch March 14, 2022 12:28
Aiee added a commit to Aiee/nebula that referenced this pull request Mar 14, 2022
@Aiee
Update error message when connect with an out-of-date client (vesoft-…
283e29c 
…inc#4021)

* Update error message

* Do clientAddr check before FLAGS_enable_authorize check

* Fix typo
yixinglu pushed a commit that referenced this pull request Mar 14, 2022
@Aiee @darionyaphet
@Sophie-Xie @jiayuehua
Cherry pick v3.0.1 (#4027)
2e938c7 
* unify leader change and machine not found (#4022)

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* delete src/common/encryption src/common/base/stringunorderedmap (#3867)

* delete src/common/encryption

* encryption format code

* Update error message when connect with an out-of-date client (#4021)

* Update error message

* Do clientAddr check before FLAGS_enable_authorize check

* Fix typo

Co-authored-by: yaphet <4414314+darionyaphet@users.noreply.github.com>
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Co-authored-by: yuehua.jia <3423893+jiayuehua@users.noreply.github.com>
@jamieliu1023 jamieliu1023 mentioned this pull request Mar 19, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HarrisChu HarrisChu HarrisChu approved these changes

@Shylock-Hg Shylock-Hg Shylock-Hg approved these changes

@czpmango czpmango czpmango left review comments

@jievince jievince jievince left review comments

@yixinglu yixinglu Awaiting requested review from yixinglu

Assignees
No one assigned
Labels
cherry-pick-v3.0 PR: need cherry-pick to this version ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Aiee @HarrisChu @yixinglu @czpmango @Shylock-Hg @jievince @Sophie-Xie