unify leader change and machine not found #4022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarrisChu
approved these changes
Mar 14, 2022
Aiee
approved these changes
Mar 14, 2022
critical27
reviewed
Mar 14, 2022
| @@ -743,7 +743,8 @@ void MetaClient::getResponse(Request req, | |||
| // succeeded | |||
| pro.setValue(respGen(std::move(resp))); | |||
| return; | |||
| } else if (code == nebula::cpp2::ErrorCode::E_LEADER_CHANGED) { | |||
| } else if (code == nebula::cpp2::ErrorCode::E_LEADER_CHANGED || | |||
| code == nebula::cpp2::ErrorCode::E_MACHINE_NOT_FOUND) { | |||
There was a problem hiding this comment.
If so, why not just return E_MACHINE_NOT_FOUND when the key not found in ActiveHostsMan::machineRegisted...
There was a problem hiding this comment.
when the active hosts manager not found the hosts return E_MACHINE_NOT_FOUND and set leader message
There was a problem hiding this comment.
I mean only leader could return E_MACHINE_NOT_FOUND, follower will return LEADER_CHANGED, so we don't need to have to add any code in MetaClient to handle E_MACHINE_NOT_FOUND
|
BTW, prefer to handle error code in heart beat. |
|
|
Merge first, the code could be improved later |
Sophie-Xie
added a commit
that referenced
this pull request
Mar 14, 2022
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
Aiee
pushed a commit
to Aiee/nebula
that referenced
this pull request
Mar 14, 2022
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
yixinglu
pushed a commit
that referenced
this pull request
Mar 14, 2022
* unify leader change and machine not found (#4022) Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * delete src/common/encryption src/common/base/stringunorderedmap (#3867) * delete src/common/encryption * encryption format code * Update error message when connect with an out-of-date client (#4021) * Update error message * Do clientAddr check before FLAGS_enable_authorize check * Fix typo Co-authored-by: yaphet <4414314+darionyaphet@users.noreply.github.com> Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> Co-authored-by: yuehua.jia <3423893+jiayuehua@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: