Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace obsolete RocksDB API #4395

Merged
merged 3 commits into from
Jul 12, 2022
Merged

Conversation

Qiaolin-Yu
Copy link
Contributor

@Qiaolin-Yu Qiaolin-Yu commented Jul 11, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number: #4394

Description:

  • Replace obsolete RocksDB API "backupable db" to be compatible with RocksDB in the future

How do you solve it?

  • Replace with updated RocksDB API.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

  • RocksDB has supported the updated API in very early versions, so it will not cause existing compatibility problems.

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@CLAassistant
Copy link

CLAassistant commented Jul 11, 2022

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Good.

In backupable_db.h, Use the following aliases for backward compatibility.
using BackupableDBOptions = BackupEngineOptions;

@Sophie-Xie Sophie-Xie requested a review from wenhaocs July 11, 2022 06:17
@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Jul 11, 2022
@Sophie-Xie Sophie-Xie requested a review from critical27 July 11, 2022 08:45
@codecov-commenter
Copy link

Codecov Report

Merging #4395 (624d9f9) into master (1de182c) will increase coverage by 0.06%.
The diff coverage is 70.45%.

@@            Coverage Diff             @@
##           master    #4395      +/-   ##
==========================================
+ Coverage   84.52%   84.58%   +0.06%     
==========================================
  Files        1345     1345              
  Lines      134014   134023       +9     
==========================================
+ Hits       113272   113368      +96     
+ Misses      20742    20655      -87     
Impacted Files Coverage Δ
src/daemons/GraphDaemon.cpp 60.22% <ø> (+0.44%) ⬆️
src/graph/executor/admin/SpaceExecutor.cpp 76.92% <0.00%> (ø)
src/kvstore/RocksEngine.h 83.09% <ø> (ø)
src/common/meta/GflagsManager.cpp 73.91% <50.00%> (-1.09%) ⬇️
src/storage/StorageServer.cpp 79.81% <50.00%> (-0.56%) ⬇️
src/graph/service/GraphService.cpp 73.58% <66.66%> (-0.14%) ⬇️
src/kvstore/wal/AtomicLogBuffer.cpp 96.15% <66.66%> (-1.53%) ⬇️
src/kvstore/raftex/RaftPart.cpp 70.14% <88.23%> (+0.14%) ⬆️
src/clients/meta/MetaClient.cpp 76.45% <100.00%> (+0.16%) ⬆️
src/common/time/TimezoneInfo.h 86.95% <100.00%> (+0.59%) ⬆️
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14c59e0...624d9f9. Read the comment docs.

@Sophie-Xie Sophie-Xie merged commit d53486c into vesoft-inc:master Jul 12, 2022
Sophie-Xie added a commit that referenced this pull request Aug 30, 2022
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
@Sophie-Xie Sophie-Xie added the affects/v3.2 PR/issue: this bug affects v3.2.x version. label Aug 30, 2022
Sophie-Xie added a commit that referenced this pull request Sep 6, 2022
@Sophie-Xie Sophie-Xie removed the affects/v3.2 PR/issue: this bug affects v3.2.x version. label Sep 7, 2022
Sophie-Xie added a commit that referenced this pull request Sep 8, 2022
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>
@Sophie-Xie Sophie-Xie added the affects/v3.2 PR/issue: this bug affects v3.2.x version. label Sep 8, 2022
Sophie-Xie added a commit that referenced this pull request Sep 13, 2022
* fix lookup (#4552)

fix

Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* fix split brain in raft (#4479)

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* fix invalid filter in GetProp make storage crashed (#4568)

Co-authored-by: haowen <19355821+wenhaocs@users.noreply.github.com>

* fix scan vertex/edge do not handle ttl (#4578)

* fix scan vertex/edge do not handle ttl

* use ErrorCode to unify community version and end version

* Fix #1212. Return FoldConstantExprVisitor, if status_ already failed due to found syantax errors. (#4607)

Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com>

* Avoid fatal when expression illegal. (#4618)

* Fix concurrent exception related to multi-match statement (#4605)

* fix filter executor

* Fix concurrency exception of multi-match statements

fix iterator

fix

small delete

small delete

skip iterator type handle for concurrency

small delete

fix scan edges

small delete

small delete

fix

small delete

small change

small change

fix ut

small fix

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* Prune properties(#4523)

* fix conflict

* extract attribute from properties function (#4604)

* extract attribute from properties function

* fix error

* fix subscript error

* add test case

* process scanEdges

* fix test error

* add unwind & check vidType when executing not validate (#4456)

* Update AppendVerticesExecutor.cpp

fix conflict

* Update AppendVerticesExecutor.cpp

* Replace obsolete RocksDB API (#4395)

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* Update PrunePropertiesRule.feature

* remove useless dc (#4533)

* Update PrunePropertiesRule.feature

* fix test error

Co-authored-by: kyle.cao <kyle.cao@vesoft.com>
Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Co-authored-by: liwenhui-soul <38217397+liwenhui-soul@users.noreply.github.com>
Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Co-authored-by: haowen <19355821+wenhaocs@users.noreply.github.com>
Co-authored-by: Cheng Xuntao <7731943+xtcyclist@users.noreply.github.com>
Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com>
Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com>
Co-authored-by: Qiaolin Yu <90088090+Qiaolin-Yu@users.noreply.github.com>
@Sophie-Xie Sophie-Xie added cherry-pick-v3.2 PR: need cherry-pick to this version and removed affects/v3.2 PR/issue: this bug affects v3.2.x version. labels Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.2 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants