fix split brain in raft #4479

liwenhui-soul · 2022-08-02T10:01:14Z

What type of PR is this?

bug
feature
enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

Unit test(positive and negative cases)
Function test
Performance test
N/A

Affects:

Documentation affected (Please add the label if documentation needs to be modified.)
Incompatibility (If it breaks the compatibility, please describe it and add the label.）
If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

src/kvstore/raftex/Host.cpp

critical27 · 2022-08-02T11:30:49Z

src/kvstore/raftex/RaftPart.cpp

@@ -2034,6 +2034,10 @@ void RaftPart::sendHeartbeat() {
 decltype(hosts_) hosts;
 {
 std::lock_guard<std::mutex> g(raftLock_);
+ nebula::cpp2::ErrorCode rc = canAppendLogs();


critical27 · 2022-08-09T07:42:51Z

src/kvstore/raftex/SnapshotManager.cpp

 folly::Promise<StatusOr<std::pair<LogID, TermID>>> p;
 // if use getFuture(), the future's executor is InlineExecutor, and if the promise setValue first,
 // the future's callback will be called directly in thenValue in the same thread, the Host::lock_
 // would be locked twice in one thread, this will cause deadlock
 auto fut = p.getSemiFuture().via(executor_.get());
- executor_->add([this, p = std::move(p), part, dst]() mutable {
+ executor_->add([this, termId, p = std::move(p), part, dst]() mutable {


Get term and role from RaftPart~

critical27

Generally LGTM

critical27 · 2022-08-22T02:54:02Z

src/kvstore/raftex/RaftPart.cpp

 if (status_ != Status::WAITING_SNAPSHOT) {
 VLOG(2) << idStr_ << "Begin to receive the snapshot";
+ // Check leadership


Would you add some comments about it~~

critical27

Good job

kikimo

LGTM

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* fix lookup (#4552) fix Co-authored-by: jimingquan <mingquan.ji@vesoft.com> Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * fix split brain in raft (#4479) Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * fix invalid filter in GetProp make storage crashed (#4568) Co-authored-by: haowen <19355821+wenhaocs@users.noreply.github.com> * fix scan vertex/edge do not handle ttl (#4578) * fix scan vertex/edge do not handle ttl * use ErrorCode to unify community version and end version * Fix #1212. Return FoldConstantExprVisitor, if status_ already failed due to found syantax errors. (#4607) Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com> * Avoid fatal when expression illegal. (#4618) * Fix concurrent exception related to multi-match statement (#4605) * fix filter executor * Fix concurrency exception of multi-match statements fix iterator fix small delete small delete skip iterator type handle for concurrency small delete fix scan edges small delete small delete fix small delete small change small change fix ut small fix Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * Prune properties(#4523) * fix conflict * extract attribute from properties function (#4604) * extract attribute from properties function * fix error * fix subscript error * add test case * process scanEdges * fix test error * add unwind & check vidType when executing not validate (#4456) * Update AppendVerticesExecutor.cpp fix conflict * Update AppendVerticesExecutor.cpp * Replace obsolete RocksDB API (#4395) Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * Update PrunePropertiesRule.feature * remove useless dc (#4533) * Update PrunePropertiesRule.feature * fix test error Co-authored-by: kyle.cao <kyle.cao@vesoft.com> Co-authored-by: jimingquan <mingquan.ji@vesoft.com> Co-authored-by: liwenhui-soul <38217397+liwenhui-soul@users.noreply.github.com> Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> Co-authored-by: haowen <19355821+wenhaocs@users.noreply.github.com> Co-authored-by: Cheng Xuntao <7731943+xtcyclist@users.noreply.github.com> Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com> Co-authored-by: shylock <33566796+Shylock-Hg@users.noreply.github.com> Co-authored-by: Qiaolin Yu <90088090+Qiaolin-Yu@users.noreply.github.com>

liwenhui-soul requested a review from critical27 as a code owner August 2, 2022 10:01

liwenhui-soul added ready-for-testing PR: ready for the CI test ready for review labels Aug 2, 2022

liwenhui-soul force-pushed the raft branch from fff0210 to 3886090 Compare August 2, 2022 10:03

Sophie-Xie requested a review from kikimo August 2, 2022 10:03

critical27 reviewed Aug 2, 2022

View reviewed changes

src/kvstore/raftex/Host.cpp Outdated Show resolved Hide resolved

liwenhui-soul force-pushed the raft branch from 3886090 to 0ded9ab Compare August 2, 2022 10:56

critical27 reviewed Aug 2, 2022

View reviewed changes

liwenhui-soul force-pushed the raft branch from 0ded9ab to 720abc6 Compare August 8, 2022 09:43

critical27 reviewed Aug 9, 2022

View reviewed changes

liwenhui-soul force-pushed the raft branch from 720abc6 to 610168a Compare August 9, 2022 11:56

fix split brain in raft

a181c97

liwenhui-soul force-pushed the raft branch from 610168a to a181c97 Compare August 9, 2022 12:18

liwenhui-soul requested a review from critical27 August 10, 2022 07:56

critical27 reviewed Aug 22, 2022

View reviewed changes

critical27 approved these changes Aug 22, 2022

View reviewed changes

kikimo approved these changes Aug 22, 2022

View reviewed changes

liwenhui-soul and others added 2 commits August 22, 2022 11:06

Merge branch 'master' into raft

37efb88

Merge branch 'master' into raft

4767db3

dutor merged commit ff8daf1 into vesoft-inc:master Aug 22, 2022

wey-gu mentioned this pull request Aug 27, 2022

Weekly Report 2022-08-26 vesoft-inc/nebula-community#129

Closed

Sophie-Xie added the affects/v3.2 PR/issue: this bug affects v3.2.x version. label Aug 30, 2022

Sophie-Xie added a commit that referenced this pull request Aug 30, 2022

fix split brain in raft (#4479)

46a7b5f

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

Sophie-Xie added a commit that referenced this pull request Sep 7, 2022

fix split brain in raft (#4479)

e7663e6

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

Sophie-Xie added cherry-pick-v3.2 PR: need cherry-pick to this version and removed affects/v3.2 PR/issue: this bug affects v3.2.x version. labels Sep 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix split brain in raft #4479

fix split brain in raft #4479

liwenhui-soul commented Aug 2, 2022 •

edited

Loading

critical27 Aug 2, 2022

critical27 Aug 9, 2022

critical27 left a comment

critical27 Aug 22, 2022

critical27 left a comment

kikimo left a comment

fix split brain in raft #4479

fix split brain in raft #4479

Conversation

liwenhui-soul commented Aug 2, 2022 • edited Loading

What type of PR is this?

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Release notes:

critical27 Aug 2, 2022

Choose a reason for hiding this comment

critical27 Aug 9, 2022

Choose a reason for hiding this comment

critical27 left a comment

Choose a reason for hiding this comment

critical27 Aug 22, 2022

Choose a reason for hiding this comment

critical27 left a comment

Choose a reason for hiding this comment

kikimo left a comment

Choose a reason for hiding this comment

liwenhui-soul commented Aug 2, 2022 •

edited

Loading