Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync thrift modification of incremental backup and restore #4527

Conversation

panda-sheep
Copy link
Contributor

@panda-sheep panda-sheep commented Aug 16, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

sync thrift modification of incremental backup and restore from ent version
Involves the following pr:
https://github.com/vesoft-inc/nebula-ent/pull/893
https://github.com/vesoft-inc/nebula-ent/pull/972

close https://github.com/vesoft-inc/nebula-ent/issues/976

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@panda-sheep panda-sheep requested a review from wenhaocs August 19, 2022 07:37
@Sophie-Xie Sophie-Xie added the incompatible PR: incompatible with the recently released version label Aug 22, 2022
@critical27 critical27 merged commit 891b2c6 into vesoft-inc:master Aug 22, 2022
@panda-sheep panda-sheep deleted the sync_thrift_from_ent_for_increment_backup_restore branch August 22, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
incompatible PR: incompatible with the recently released version ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants