Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stats log print to console when we start process. #4550

Merged
merged 6 commits into from
Aug 22, 2022

Conversation

Milittle
Copy link
Contributor

@Milittle Milittle commented Aug 17, 2022

we before setupLogging, init our stats, when we adjust high level verbose
log. it will be output logs to console.

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number: I do not pull new issue for this.

Description:

we before setupLogging, init our stats, when we adjust high level verbose
log. it will be output logs to console.

How do you solve it?

I adjust the init stats order from main process in Metad and Storaged

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

we before setLogging, init our stats, when we adjust high level verbose
log. it will be output logs to console.
@Sophie-Xie Sophie-Xie added the ready-for-testing PR: ready for the CI test label Aug 18, 2022
Copy link
Contributor

@panda-sheep panda-sheep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks for your contribution

@jievince jievince requested a review from dutor August 18, 2022 06:21
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2022

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.70%. Comparing base (9239b32) to head (60f6c09).
Report is 513 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4550      +/-   ##
==========================================
+ Coverage   84.67%   84.70%   +0.03%     
==========================================
  Files        1354     1355       +1     
  Lines      134943   135012      +69     
==========================================
+ Hits       114261   114365     +104     
+ Misses      20682    20647      -35     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@critical27 critical27 merged commit 403aaa4 into vesoft-inc:master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants