Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable count(distinct *) #4553

Merged
merged 5 commits into from
Aug 24, 2022
Merged

Disable count(distinct *) #4553

merged 5 commits into from
Aug 24, 2022

Conversation

czpmango
Copy link
Contributor

@czpmango czpmango commented Aug 18, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

I tested mysql/neo4j and none of them support count(distinct *).

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@czpmango czpmango added ready-for-testing PR: ready for the CI test ready for review labels Aug 18, 2022
@czpmango czpmango requested review from Aiee and jievince August 18, 2022 08:20
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2022

Codecov Report

Merging #4553 (2e7f46a) into master (9239b32) will increase coverage by 0.01%.
The diff coverage is 73.16%.

@@            Coverage Diff             @@
##           master    #4553      +/-   ##
==========================================
+ Coverage   84.67%   84.69%   +0.01%     
==========================================
  Files        1354     1355       +1     
  Lines      134943   135009      +66     
==========================================
+ Hits       114261   114343      +82     
+ Misses      20682    20666      -16     
Impacted Files Coverage Δ
src/graph/executor/query/GetDstBySrcExecutor.cpp 86.20% <0.00%> (-1.52%) ⬇️
src/graph/optimizer/OptGroup.cpp 90.97% <ø> (-0.14%) ⬇️
src/parser/test/ParserTest.cpp 100.00% <ø> (ø)
src/storage/query/GetDstBySrcProcessor.h 100.00% <ø> (ø)
src/storage/query/GetDstBySrcProcessor.cpp 63.68% <40.57%> (-15.27%) ⬇️
src/common/datatypes/Value.cpp 74.36% <80.00%> (-1.09%) ⬇️
...r/rule/RemoveProjectDedupBeforeGetDstBySrcRule.cpp 87.17% <87.17%> (ø)
src/graph/planner/ngql/GoPlanner.cpp 98.84% <89.47%> (-0.45%) ⬇️
src/common/datatypes/DataSet.h 79.46% <100.00%> (+0.18%) ⬆️
src/common/datatypes/List.h 94.54% <100.00%> (+0.20%) ⬆️
... and 47 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Sophie-Xie
Copy link
Contributor

Does it break compatibility?

@czpmango
Copy link
Contributor Author

Does it break compatibility?

Not in a sense, because it was a bug before.

@Shylock-Hg Shylock-Hg added the incompatible PR: incompatible with the recently released version label Aug 22, 2022
@czpmango czpmango removed the incompatible PR: incompatible with the recently released version label Aug 22, 2022
@czpmango
Copy link
Contributor Author

Does it break compatibility?

Not in a sense, because it was a bug before.

@Shylock-Hg

@Sophie-Xie Sophie-Xie merged commit 0fb092a into vesoft-inc:master Aug 24, 2022
@Sophie-Xie Sophie-Xie added the doc affected PR: improvements or additions to documentation label Oct 20, 2022
@foesa-yang foesa-yang self-assigned this Oct 20, 2022
@foesa-yang foesa-yang removed the doc affected PR: improvements or additions to documentation label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants