Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix subgraph crash #4698

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Conversation

nevermore3
Copy link
Contributor

@nevermore3 nevermore3 commented Oct 9, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

close #4694

Description:

In a distributed environment, getNeighbor may return multiple datasets, and due to filter conditions, not every dataset has data

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@nevermore3 nevermore3 added ready-for-testing PR: ready for the CI test ready for review labels Oct 9, 2022
@nevermore3 nevermore3 requested review from dutor and codesigner October 9, 2022 09:05
Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Sophie-Xie Sophie-Xie added the cherry-pick-v3.3 PR: need cherry-pick to this version label Oct 9, 2022
@Sophie-Xie Sophie-Xie merged commit f09683b into vesoft-inc:master Oct 9, 2022
Sophie-Xie pushed a commit that referenced this pull request Oct 9, 2022
@nevermore3 nevermore3 deleted the fix_graph_crash branch October 9, 2022 11:09
critical27 pushed a commit that referenced this pull request Oct 12, 2022
* optimize for the last step of go n steps plan (#4690)

* optimize for the last step of go n steps plan

* improve some comments

* change time point calculate in ttl (#4683)

* change time point calculate in ttl

* fix ttl test

* enlarge the ttl sleep interval in the test

* fix ttl in index

* Revert "enlarge the ttl sleep interval in the test"

This reverts commit e37bf51.

* change wall time in mock data

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* fix graph crash (#4698)

* fix_ambiguous_case (#4701)

* fix_ambiguous_case

* change in any order to in order'

* fix map hash method (#4707)

Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com>
Co-authored-by: pengwei.song <90180021+pengweisong@users.noreply.github.com>
Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.3 PR: need cherry-pick to this version ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

graph crashed when get subgraph with tag filter
4 participants