Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix map hash method #4707

Merged
merged 1 commit into from
Oct 11, 2022
Merged

fix map hash method #4707

merged 1 commit into from
Oct 11, 2022

Conversation

jievince
Copy link
Contributor

@jievince jievince commented Oct 10, 2022 •
edited
Loading

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Fix #4702

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@jievince jievince added the ready-for-testing PR: ready for the CI test label Oct 10, 2022
@jievince jievince added this to the v3.3.0 milestone Oct 10, 2022
@jievince jievince force-pushed the map-hasher branch 2 times, most recently from 695b394 to c99899b Compare October 11, 2022 03:31
@codesigner codesigner merged commit adf9d87 into vesoft-inc:master Oct 11, 2022
@jievince jievince deleted the map-hasher branch October 11, 2022 09:24
Sophie-Xie pushed a commit that referenced this pull request Oct 12, 2022
@jievince @Sophie-Xie
fix map hash method (#4707)
4f73af1
@Sophie-Xie Sophie-Xie added the cherry-pick-v3.3 PR: need cherry-pick to this version label Oct 12, 2022
critical27 pushed a commit that referenced this pull request Oct 12, 2022
@Sophie-Xie @jievince
@pengweisong @nevermore3
Cherry pick 3.3.0 (1008-1011） (#4695)
2af23ed 
* optimize for the last step of go n steps plan (#4690)

* optimize for the last step of go n steps plan

* improve some comments

* change time point calculate in ttl (#4683)

* change time point calculate in ttl

* fix ttl test

* enlarge the ttl sleep interval in the test

* fix ttl in index

* Revert "enlarge the ttl sleep interval in the test"

This reverts commit e37bf51.

* change wall time in mock data

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* fix graph crash (#4698)

* fix_ambiguous_case (#4701)

* fix_ambiguous_case

* change in any order to in order'

* fix map hash method (#4707)

Co-authored-by: jie.wang <38901892+jievince@users.noreply.github.com>
Co-authored-by: pengwei.song <90180021+pengweisong@users.noreply.github.com>
Co-authored-by: jimingquan <mingquan.ji@vesoft.com>
@wey-gu wey-gu mentioned this pull request Oct 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aiee Aiee Aiee approved these changes

@nevermore3 nevermore3 nevermore3 approved these changes

@Shylock-Hg Shylock-Hg Awaiting requested review from Shylock-Hg

@czpmango czpmango Awaiting requested review from czpmango

Assignees
No one assigned
Labels
cherry-pick-v3.3 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

overflow_error: robin_hood::map overflow
5 participants
@jievince @nevermore3 @Aiee @codesigner @Sophie-Xie