Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix aggregate expression type deduce #4706

Merged
merged 3 commits into from
Oct 13, 2022

Conversation

czpmango
Copy link
Contributor

@czpmango czpmango commented Oct 10, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

#4711

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@czpmango czpmango marked this pull request as draft October 10, 2022 10:27
@czpmango czpmango closed this Oct 12, 2022
@czpmango czpmango reopened this Oct 12, 2022
@czpmango czpmango marked this pull request as ready for review October 12, 2022 02:10
@czpmango czpmango added ready-for-testing PR: ready for the CI test ready for review labels Oct 12, 2022
nevermore3
nevermore3 previously approved these changes Oct 12, 2022
jievince
jievince previously approved these changes Oct 12, 2022
add test case

fix tck

fix tck
@czpmango czpmango force-pushed the fix/agg-expr-deduce branch from 4bea0f1 to 3a7f1ec Compare October 13, 2022 03:05
@codesigner codesigner merged commit 74a6577 into vesoft-inc:master Oct 13, 2022
@Sophie-Xie Sophie-Xie added the cherry-pick-v3.3 PR: need cherry-pick to this version label Oct 17, 2022
Sophie-Xie pushed a commit that referenced this pull request Oct 17, 2022
* fix aggregate expression type deduce

add test case

fix tck

fix tck

* fix ut
critical27 added a commit that referenced this pull request Oct 17, 2022
* Fix aggregate expression type deduce (#4706)

* fix aggregate expression type deduce

add test case

fix tck

fix tck

* fix ut

* fix hdfs download command will always return succeeded (#4723)

* remove rebuild index guard when job finished (#4722)

* remove rebuild index guard when job finished

* fix reenter problem

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* split experimental_feature flag (#4728)

* split experimental_feature flag

* eof

* forbid insert vertex when vertex_key flag is off (#4727)

* forbid insert vertex when vertex_key flag is off

* fix issue ent#1420

* fix test case

* fix format

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

Co-authored-by: kyle.cao <kyle.cao@vesoft.com>
Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Co-authored-by: Alex Xing <90179377+SuperYoko@users.noreply.github.com>
@jinyingsunny
Copy link

checked on 3.3-rc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-v3.3 PR: need cherry-pick to this version ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants