-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix aggregate expression type deduce #4706
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nevermore3
previously approved these changes
Oct 12, 2022
czpmango
force-pushed
the
fix/agg-expr-deduce
branch
from
October 12, 2022 05:58
ed60620
to
cc995d6
Compare
jievince
previously approved these changes
Oct 12, 2022
add test case fix tck fix tck
czpmango
force-pushed
the
fix/agg-expr-deduce
branch
from
October 13, 2022 03:05
4bea0f1
to
3a7f1ec
Compare
jievince
approved these changes
Oct 13, 2022
Aiee
approved these changes
Oct 13, 2022
Sophie-Xie
pushed a commit
that referenced
this pull request
Oct 17, 2022
* fix aggregate expression type deduce add test case fix tck fix tck * fix ut
critical27
added a commit
that referenced
this pull request
Oct 17, 2022
* Fix aggregate expression type deduce (#4706) * fix aggregate expression type deduce add test case fix tck fix tck * fix ut * fix hdfs download command will always return succeeded (#4723) * remove rebuild index guard when job finished (#4722) * remove rebuild index guard when job finished * fix reenter problem Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> * split experimental_feature flag (#4728) * split experimental_feature flag * eof * forbid insert vertex when vertex_key flag is off (#4727) * forbid insert vertex when vertex_key flag is off * fix issue ent#1420 * fix test case * fix format Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com> Co-authored-by: kyle.cao <kyle.cao@vesoft.com> Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com> Co-authored-by: Alex Xing <90179377+SuperYoko@users.noreply.github.com>
checked on 3.3-rc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick-v3.3
PR: need cherry-pick to this version
ready for review
ready-for-testing
PR: ready for the CI test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What problem(s) does this PR solve?
Issue(s) number:
#4711
Description:
How do you solve it?
Special notes for your reviewer, ex. impact of this fix, design document, etc:
Checklist:
Tests:
Affects:
Release notes:
Please confirm whether to be reflected in release notes and how to describe: