Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix hdfs download command will always return succeeded sometimes #4723

Merged
merged 1 commit into from
Oct 14, 2022
Merged

fix hdfs download command will always return succeeded sometimes #4723

merged 1 commit into from
Oct 14, 2022

Conversation

critical27
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

check errno from folly::subProcess

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@critical27 critical27 added ready-for-testing PR: ready for the CI test cherry-pick-v3.3 PR: need cherry-pick to this version labels Oct 14, 2022
@Sophie-Xie Sophie-Xie merged commit b552f9b into vesoft-inc:master Oct 14, 2022
@critical27 critical27 deleted the fix branch October 14, 2022 06:56
@wey-gu wey-gu mentioned this pull request Oct 15, 2022
Closed
Sophie-Xie pushed a commit that referenced this pull request Oct 17, 2022
@critical27 @Sophie-Xie
fix hdfs download command will always return succeeded (#4723)
8002213
critical27 added a commit that referenced this pull request Oct 17, 2022
@Sophie-Xie @czpmango
@critical27 @SuperYoko
Cherry pick 3.3 (1013-1017) (#4735)
cf152be 
* Fix aggregate expression type deduce (#4706)

* fix aggregate expression type deduce

add test case

fix tck

fix tck

* fix ut

* fix hdfs download command will always return succeeded (#4723)

* remove rebuild index guard when job finished (#4722)

* remove rebuild index guard when job finished

* fix reenter problem

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

* split experimental_feature flag (#4728)

* split experimental_feature flag

* eof

* forbid insert vertex when vertex_key flag is off (#4727)

* forbid insert vertex when vertex_key flag is off

* fix issue ent#1420

* fix test case

* fix format

Co-authored-by: Sophie <84560950+Sophie-Xie@users.noreply.github.com>

Co-authored-by: kyle.cao <kyle.cao@vesoft.com>
Co-authored-by: Doodle <13706157+critical27@users.noreply.github.com>
Co-authored-by: Alex Xing <90179377+SuperYoko@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperYoko SuperYoko SuperYoko approved these changes

@panda-sheep panda-sheep panda-sheep approved these changes

@liwenhui-soul liwenhui-soul Awaiting requested review from liwenhui-soul

@jinyingsunny jinyingsunny Awaiting requested review from jinyingsunny

Assignees
No one assigned
Labels
cherry-pick-v3.3 PR: need cherry-pick to this version ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@critical27 @panda-sheep @SuperYoko @Sophie-Xie