Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize left join predicate & Eliminate useless appendVertices #4980

Merged
merged 5 commits into from
Dec 7, 2022
Merged

optimize left join predicate & Eliminate useless appendVertices #4980

merged 5 commits into from
Dec 7, 2022

Conversation

jievince
Copy link
Contributor

@jievince jievince commented Dec 3, 2022

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.）
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

yixinglu
yixinglu reviewed Dec 6, 2022
View reviewed changes
Copy link
Contributor

@yixinglu yixinglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some TCK tests

src/graph/optimizer/rule/OptimizeLeftJoinPredicateRule.cpp Outdated Show resolved Hide resolved
src/graph/optimizer/rule/OptimizeLeftJoinPredicateRule.cpp Show resolved Hide resolved
@czpmango czpmango added ready-for-testing PR: ready for the CI test ready for review labels Dec 6, 2022
@jievince jievince force-pushed the opt-left-join branch 4 times, most recently from 89c77b7 to 8629c57 Compare December 6, 2022 13:01
Aiee
Aiee previously approved these changes Dec 6, 2022
View reviewed changes
@jievince jievince force-pushed the opt-left-join branch 2 times, most recently from 2585d4b to eef7b5c Compare December 6, 2022 13:12
Aiee
Aiee previously approved these changes Dec 6, 2022
View reviewed changes
yixinglu
yixinglu previously approved these changes Dec 6, 2022
View reviewed changes
@jievince jievince dismissed stale reviews from yixinglu and Aiee via 7357cf5 December 6, 2022 15:55
@yixinglu yixinglu requested a review from czpmango December 7, 2022 02:51
@yixinglu yixinglu merged commit 5ad688b into vesoft-inc:master Dec 7, 2022
@wey-gu wey-gu mentioned this pull request Dec 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czpmango czpmango czpmango approved these changes

@yixinglu yixinglu yixinglu approved these changes

@Aiee Aiee Awaiting requested review from Aiee

Assignees
No one assigned
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jievince @yixinglu @Aiee @czpmango