Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove virtual function in RowReader #5381

Merged
merged 4 commits into from
Mar 14, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/codec/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@

nebula_add_library(
codec_obj OBJECT
RowReader.cpp
RowReaderV1.cpp
RowReaderV2.cpp
RowWriterV2.cpp
RowReaderWrapper.cpp
Expand Down
2 changes: 1 addition & 1 deletion src/codec/NebulaCodecImpl.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

#include "codec/NebulaCodecImpl.h"

#include "codec/RowReader.h"
#include "codec/RowReaderWrapper.h"
#include "codec/RowWriterV2.h"
#include "common/base/Base.h"

Expand Down
24 changes: 0 additions & 24 deletions src/codec/NebulaCodecImpl.h

This file was deleted.

61 changes: 0 additions & 61 deletions src/codec/RowReader.cpp

This file was deleted.

180 changes: 0 additions & 180 deletions src/codec/RowReader.h

This file was deleted.

Loading