Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove virtual function in RowReader #5381

Merged
merged 4 commits into from
Mar 14, 2023
Merged

Conversation

critical27
Copy link
Contributor

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Since we don't support data of 1.x long ago, we don't need the virtual interface of RowReader anymore. So I removed RowReader and RowReaderV1.

RowReaderWrapper now only contains a pointer of RowReaderV2. No more virtual function called.

After this PR, the virtual interface of SchemaProviderIf could be removed as well, I'll handle it later

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

@HarrisChu, this PR may or may not improve the performance, could pay some attention to it later.

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@cangfengzhs
Copy link
Contributor

Since you modified it, why is it still called RowReaderV2? V2 can be deleted

@critical27
Copy link
Contributor Author

Since you modified it, why is it still called RowReaderV2? V2 can be deleted

For now, just keep the old naming, there is also a RowWriterV2...
All code use RowReaderWrapper, we could remove it and rename RowReaderV2 to RowReader together if necessary.

Copy link
Contributor

@pengweisong pengweisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

Copy link
Contributor

@dutor dutor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Sophie-Xie Sophie-Xie merged commit 41380dc into vesoft-inc:master Mar 14, 2023
@critical27 critical27 deleted the reader branch March 15, 2023 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants