Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove virtual interface in SchemaProviderIf #5410

Merged
merged 3 commits into from
Mar 20, 2023

Conversation

critical27
Copy link
Contributor

@critical27 critical27 commented Mar 17, 2023

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

Follow up of #5381, since RowReader has been removed, we could remove the virtual interface SchemaProviderIf further more. It has two derived class, NebulaSchemaProvider is the one we used, ResultSchemaProvider is the one that compatible with RowReaderV1, which is not used anymore.

How do you solve it?

In this PR, all schema is replaced with NebulaSchemaProvider, the base SchemaProviderIf and derived ResultSchemaProvider along with outdated test, RowReaderV1 are removed.

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@critical27 critical27 added ready-for-testing PR: ready for the CI test ready for review labels Mar 17, 2023
@critical27 critical27 changed the title Schema Remove virtual interface in SchemaProviderIf Mar 20, 2023
Iterator& operator+(uint16_t steps) {
if (field_) {
index_ += steps;
field_ = schema_->field(index_);
Copy link
Contributor

@pengweisong pengweisong Mar 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if index_ out of range, operator*() will raise exception. Is this expected?

Copy link
Contributor

@pengweisong pengweisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@Sophie-Xie Sophie-Xie merged commit 5cb0bff into vesoft-inc:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants