fix: refactor DynamicGraph print method #1060
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
clang-tidy review says "All clean, LGTM! 👍" |
|
@Abhinavcode13, the test failures are mostly due to the old graph printing style in tests. |
vgvassilev
reviewed
Aug 26, 2024
| std::unordered_set<size_t> visited; | ||
|
|
||
| // Recursive function to print nodes with indentation based on depth. | ||
| std::function<void(size_t, int)> printNode = [&](size_t nodeId, int depth) { |
There was a problem hiding this comment.
Suggested change
| std::function<void(size_t, int)> printNode = [&](size_t nodeId, int depth) { | |
| auto printNode = [&](size_t nodeId, int depth) { |
I believe we can the recursion with the cheaper iteration approach.
Co-authored-by: Vassil Vassilev <v.g.vassilev@gmail.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| // Recursively print all children (nodes connected by edges). | ||
| for (size_t destId : m_adjList[nodeId]) { | ||
| printNode(destId, depth + 1); |
There was a problem hiding this comment.
warning: variable 'printNode' declared with deduced type 'auto' cannot appear in its own initializer [clang-diagnostic-error]
printNode(destId, depth + 1);
^
Abhinavcode13
changed the title
|
clang-tidy review says "All clean, LGTM! 👍" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1009