-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refactor DynamicGraph print method #1060
Open
Abhinavcode13
wants to merge
3
commits into
vgvassilev:master
Choose a base branch
from
Abhinavcode13:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -110,21 +110,46 @@ template <typename T> class DynamicGraph { | |
|
||
/// Print the nodes and edges in the graph. | ||
void print() { | ||
// First print the nodes with their insertion order. | ||
for (const T& node : m_nodes) { | ||
std::pair<bool, int> nodeInfo = m_nodeMap[node]; | ||
std::cout << (std::string)node << ": #" << nodeInfo.second; | ||
if (m_sources.find(nodeInfo.second) != m_sources.end()) | ||
std::cout << " (source)"; | ||
if (nodeInfo.first) | ||
std::cout << ", (done)\n"; | ||
else | ||
std::cout << ", (unprocessed)\n"; | ||
std::unordered_set<size_t> visited; | ||
|
||
// Recursive function to print nodes with indentation based on depth. | ||
std::function<void(size_t, int)> printNode = [&](size_t nodeId, int depth) { | ||
// Check if the node has been visited already to avoid cycles. | ||
if (visited.find(nodeId) != visited.end()) | ||
return; | ||
visited.insert(nodeId); | ||
|
||
// Print the node with the appropriate indentation. | ||
const T& node = m_nodes[nodeId]; | ||
std::pair<bool, int> nodeInfo = m_nodeMap[node]; | ||
std::string indent(depth * 4, ' '); | ||
std::cout << indent << "`" << (std::string)node << ": #" << nodeInfo.second; | ||
|
||
// Indicate if the node is a source and/or done. | ||
if (m_sources.find(nodeInfo.second) != m_sources.end()) | ||
std::cout << " (source)"; | ||
if (nodeInfo.first) | ||
std::cout << ", (done)\n"; | ||
else | ||
std::cout << ", (unprocessed)\n"; | ||
|
||
// Recursively print all children (nodes connected by edges). | ||
for (size_t destId : m_adjList[nodeId]) { | ||
printNode(destId, depth + 1); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. warning: variable 'printNode' declared with deduced type 'auto' cannot appear in its own initializer [clang-diagnostic-error] printNode(destId, depth + 1);
^ |
||
} | ||
}; | ||
|
||
// Start printing from the source nodes. | ||
for (size_t sourceId : m_sources) { | ||
printNode(sourceId, 0); | ||
} | ||
|
||
// If there are unvisited nodes, they are disconnected from sources, print them separately. | ||
for (size_t i = 0; i < m_nodes.size(); ++i) { | ||
if (visited.find(i) == visited.end()) { | ||
printNode(i, 0); | ||
} | ||
} | ||
// Then print the edges. | ||
for (int i = 0; i < m_nodes.size(); i++) | ||
for (size_t dest : m_adjList[i]) | ||
std::cout << i << " -> " << dest << "\n"; | ||
} | ||
|
||
/// Get the next node to be processed from the queue of nodes to be | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we can the recursion with the cheaper iteration approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abhinavcode13, ping.