Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSDK-812-817] Add extra param to services #88

Merged
merged 8 commits into from
Nov 7, 2022

Conversation

cheukt
Copy link
Member

@cheukt cheukt commented Nov 1, 2022

adds extra struct to all services. Will not be merged until the corresponding PRs on the RDK/Python SDK is ready

Copy link
Member

@njooma njooma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Since this is mostly additive, we can probably merge this in without waiting on SDK updates

@cheukt cheukt merged commit d3f3c81 into viamrobotics:main Nov 7, 2022
@cheukt cheukt deleted the add-extra-param-services branch November 7, 2022 19:46
pstrutz added a commit to pstrutz/api that referenced this pull request Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants