Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RSDK-812-817] Add extra param to services #1545

Merged
merged 17 commits into from
Nov 7, 2022

Conversation

cheukt
Copy link
Member

@cheukt cheukt commented Nov 1, 2022

adds + tests. Will merge same time as viamrobotics/api#88

@cheukt cheukt requested a review from njooma November 1, 2022 19:04
@viambot viambot added the safe to test This pull request is marked safe to test from a trusted zone label Nov 1, 2022
go.mod Outdated
@@ -370,3 +370,5 @@ require (
github.com/ziutek/mymysql v1.5.4 // indirect
golang.org/x/exp v0.0.0-20220722155223-a9213eeb770e // indirect
)

replace go.viam.com/api => ../api-cheuk // remove
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will change back

Copy link
Member

@njooma njooma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 3, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 7, 2022
@viambot viambot added safe to test This pull request is marked safe to test from a trusted zone and removed safe to test This pull request is marked safe to test from a trusted zone labels Nov 7, 2022
@cheukt cheukt merged commit 3aa621d into viamrobotics:main Nov 7, 2022
@cheukt cheukt deleted the add-services-extra-params branch November 7, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test This pull request is marked safe to test from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants