SLAM: Process images when they're of YCbCr type #1429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kkufieta
force-pushed
the
kk/demo-random-changes
branch
3 times, most recently
from
29c1e15
to
f35bbfa
Compare
kkufieta
force-pushed
the
kk/demo-random-changes
branch
from
f35bbfa
to
40a2841
Compare
kkufieta
changed the title
| if lazyImg.MIMEType() != utils.MimeTypePNG { | ||
| return nil, nil, errors.Errorf("expected mime type %v, got %v", utils.MimeTypePNG, lazyImg.MIMEType()) | ||
|
|
||
| if ycbcrImg, ok := img.(*image.YCbCr); ok { |
There was a problem hiding this comment.
I suggest adding an integration test that runs mono YCbCr images, but it's fine with me if you want to do that in a follow-up ticket.
There was a problem hiding this comment.
I'll create a follow-up ticket for this. Ticket: DATA-535
tessavitabile
approved these changes
Oct 6, 2022
| } | ||
| return lazyImg.RawData(), release, nil | ||
|
|
||
| return nil, nil, errors.Errorf("expected lazily encoded image or ycbcrImg, got %T", img) | ||
| } |
There was a problem hiding this comment.
[nit] You could change the function name to getPNGImage(), since it will not always be lazy.
There was a problem hiding this comment.
Added it to the follow-up ticket (create integration test): DATA-535
JohnN193
approved these changes
Oct 6, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the RDK side of this ticket: https://viam.atlassian.net/browse/DATA-521
Tested with: