RSDK-723 Do not sort components when ensuring config #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
maximpertsov
commented
Oct 5, 2022
| @@ -735,9 +735,6 @@ func TestManagerNewComponent(t *testing.T) { | |||
| return resource.Name{}, false | |||
| }), test.ShouldBeNil) | |||
| robotForRemote.config.Components[8].DependsOn = append(robotForRemote.config.Components[8].DependsOn, "arm3") | |||
| _, err = config.SortComponents(robotForRemote.config.Components) | |||
| test.That(t, err, test.ShouldNotBeNil) | |||
| test.That(t, err.Error(), test.ShouldEqual, "circular dependency detected in component list between arm3, board3") | |||
There was a problem hiding this comment.
we will still return a circular dependency error when we try to update the robot with this config, and this behavior is tested at the end of this test function.
This comment was marked as resolved.
This comment was marked as resolved.
cheukt
approved these changes
Oct 6, 2022
maximpertsov
deleted the
RSDK-723-false-warning-when-adding-dependencies-from-components-on-a-remote-part
branch
checked on a live robot and got the correct error:
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: RSDK-723