[RSDK-491]Retry reconnecting and checking connection by default #1499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheukt
requested changes
Oct 14, 2022
robot/client/client.go
Outdated
| } | ||
| var reconnectTime time.Duration | ||
| if rOpts.refreshEvery == nil { | ||
| reconnectTime = 10 * time.Second |
There was a problem hiding this comment.
use the defaults from dialRobotClient
There was a problem hiding this comment.
Could you elaborate a bit more? I think I may have fixed this.
There was a problem hiding this comment.
the defaults should be 10 seconds for checkConnectedTime and 1 second for reconnect time
There was a problem hiding this comment.
So just to confirm 10 for refreshTime and checkConnectedTime. 1 second for reconnectTime?
robot/client/client_options.go
Outdated
| @@ -15,12 +15,14 @@ type robotClientOpts struct { | |||
| refreshEvery *time.Duration | |||
|
|
|||
| // checkConnectedEvery is how often to check connection to the | |||
| // robot. If unset, it will not be checked automatically. | |||
| checkConnectedEvery time.Duration | |||
| // robot. If <0, it will not be refreshed automatically, if unset, | |||
robot/client/client_options.go
Outdated
|
|
||
| // reconnectEvery is how often to try reconnecting the | ||
| // robot. If unset, it will not be reconnected automatically. | ||
| reconnectEvery time.Duration | ||
| // robot. If <0, it will not be refreshed automatically, if unset, |
There was a problem hiding this comment.
can you also update the < for refreshEvery?
…and-checking-connection
…esh as something that can be specified in config
…and-checking-connection
I cleaned up dialRobotClient and added RefreshInterval to the remote config as well. |
cheukt
requested changes
Oct 18, 2022
config/config.go
Outdated
| @@ -128,6 +128,7 @@ type Remote struct { | |||
| Insecure bool `json:"insecure"` | |||
| ConnectionCheckInterval time.Duration `json:"connection_check_interval,omitempty"` | |||
| ReconnectInterval time.Duration `json:"reconnect_interval,omitempty"` | |||
| RefreshInterval time.Duration `json:"refresh_interval,omitempty"` | |||
There was a problem hiding this comment.
while I agree with this change, you will also have to make changes to proto_conversion.go plus the api repo (since the remote config proto will have changed) and then update the app repo after that. so we can leave this change out of this PR and make a ticket or make the rest of the changes too
There was a problem hiding this comment.
👍 makes sense, ill remove it
robot/client/client.go
Outdated
| } | ||
| var reconnectTime time.Duration | ||
| if rOpts.refreshEvery == nil { | ||
| reconnectTime = 10 * time.Second |
There was a problem hiding this comment.
the defaults should be 10 seconds for checkConnectedTime and 1 second for reconnect time
| connectionCheckInterval := config.ConnectionCheckInterval | ||
| if connectionCheckInterval == 0 { | ||
| connectionCheckInterval = 10 * time.Second | ||
| rOpts := []client.RobotClientOption{client.WithDialOptions(dialOpts...)} |
cheukt
approved these changes
Oct 18, 2022
…and-checking-connection
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
similar to how we make clients refresh by default, we are doing the same for reconnecting and checking connection status