-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RSDK-578 Pass op id through to remotes rdk #1501
Merged
maximpertsov
merged 13 commits into
viamrobotics:main
from
maximpertsov:RSDK-578-pass-op-id-through-to-remotes-rdk
Oct 20, 2022
Merged
RSDK-578 Pass op id through to remotes rdk #1501
maximpertsov
merged 13 commits into
viamrobotics:main
from
maximpertsov:RSDK-578-pass-op-id-through-to-remotes-rdk
Oct 20, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximpertsov
force-pushed
the
RSDK-578-pass-op-id-through-to-remotes-rdk
branch
from
October 14, 2022 19:10
9d69921
to
cc994cb
Compare
maximpertsov
force-pushed
the
RSDK-578-pass-op-id-through-to-remotes-rdk
branch
3 times, most recently
from
October 18, 2022 19:41
4d3a470
to
684db1a
Compare
cheukt
reviewed
Oct 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few questions but generally looks good
maximpertsov
force-pushed
the
RSDK-578-pass-op-id-through-to-remotes-rdk
branch
2 times, most recently
from
October 19, 2022 17:25
92a39d2
to
0d528e2
Compare
maximpertsov
force-pushed
the
RSDK-578-pass-op-id-through-to-remotes-rdk
branch
from
October 19, 2022 20:10
0d528e2
to
efcb93b
Compare
cheukt
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://viam.atlassian.net/browse/RSDK-578
Add client interceptors to pass opids from client to server, and update server interceptors to re-use client-sent opids.
Prerequisites: